-
Notifications
You must be signed in to change notification settings - Fork 53
Version dropdown #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version dropdown #1095
Conversation
7b2de35 to
3a9d77a
Compare
|
Change this to the new syntax: Here's the Polaris version: |
|
I think we're still missing changes from: I'm seeing |
|
@altheaden, one more place that needs updating: MPAS-Analysis/suite/run_suite.bash Lines 43 to 45 in 909e6c9
|
3a9d77a to
ba283b0
Compare
|
@xylar I think the missing files and other issues you noticed have been fixed now. Can you take another look when you get a chance? |
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@altheaden, we're almost there! Just a few more small changes are needed. With these, I was able to run the developer test suite and get a version of the documentation with the dropdown:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/version-dropdown/docs/test/
ba283b0 to
6c0c859
Compare
|
@xylar I fixed those issues and located one more place where things needed updating. Does everything look okay to you? |
|
Ah, great! Thanks for finding the tutorial as well! I was tempted to just merge but I think I should run the test suite with the latest changes to make sure everything works. I'll report back soon. |
xylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR switches the documentation workflows for MPAS-Analysis to use
sphinxwith @xylar's custom version switcher instead of usingsphinx-multiversion.Checklist
Testingcomment in the PR documents testing used to verify the changes