-
Notifications
You must be signed in to change notification settings - Fork 40
New Mesh: SOwISC12to30E3r4 #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b54306 to
959da20
Compare
Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
be2486f to
b5e6880
Compare
Updated Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
|
I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions. |
e512590 to
824f8f5
Compare
Another Updated Comparison with SOwISC12to30E3r3Here are the And the same but SORRM r3 with BedMachine topography from #807: |
|
@xylar have you been looking at all at |
MOAB commands are updated to be more like recent development in remap_topography and are organized into more helper methods.
TestingTested on an 11-year G-case as described in E3SM-Ocean-Discussion/E3SM#120 |
|
@matthewhoffman and @cbegeman, if you could review this along with E3SM-Project/E3SM#7195, that would be wonderful! |
cbegeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of testing and visual inspection of these code changes. Thanks @xylar!
|
@maltrud, I agree, that's what I attribute those changes to, as well. The freshening seems like a move in the wrong direction, right? So something we may want to revisit (separate from this PR). |
compass/ocean/tests/global_ocean/mesh/remap_mali_topography/ais_4to20km.cfg
Show resolved
Hide resolved
|
@matthewhoffman, anything else? |
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , no, I don't have any other suggestions.
|
Great, thanks so much @matthewhoffman and @cbegeman!!! |









Long name: SOwISC12to30kmL80E3SMv3r4
This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:
It is intended to be similar to the Icos30 mesh except in the Southern Ocean and around Antarctica.
This mesh differs from r3 in #807 in that:
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesTestingin this PR) any testing that was used to verify the changes