Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jun 10, 2024

Long name: SOwISC12to30kmL80E3SMv3r4

This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:

  • 12 km resolution around Antarctica
  • 30 km elsewhere

It is intended to be similar to the Icos30 mesh except in the Southern Ocean and around Antarctica.

This mesh differs from r3 in #807 in that:

  • MALI topography as well as masks for land ice, floating ice and ocean get combined with BedMachine Antarctica/GEBCO.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging E3SM PR required labels Jun 10, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jun 10, 2024

This is based off of #807 (which is based off of #813) so it will be a bit before this is ready to go in. It also needs documentation.

@xylar xylar force-pushed the add-mali-topo branch 3 times, most recently from 0b54306 to 959da20 Compare June 12, 2024 16:17
@xylar
Copy link
Collaborator Author

xylar commented Jun 12, 2024

Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI topography:
mali_topo_land_ice_mask

And the same but with BedMachine from #807:
sowiscr3_land_ice_mask

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from be2486f to b5e6880 Compare July 8, 2024 12:36
@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM mesh with MALI (AIS_2to10km) topography:
sorrm_ais_2to10km_land_ice_mask

And the same but with BedMachine from #807:
sorrm_r3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Jul 8, 2024

I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions.

@xylar xylar force-pushed the add-mali-topo branch 2 times, most recently from e512590 to 824f8f5 Compare July 26, 2024 09:31
@xylar xylar self-assigned this Oct 22, 2024
@xylar xylar requested a review from matthewhoffman October 22, 2024 14:41
@xylar xylar changed the title Add a step for remapping topography from MALI New Mesh: SOwISC12to30E3r4 Oct 22, 2024
@xylar xylar added the new mesh An E3SM mesh for special review label Oct 22, 2024
@xylar xylar marked this pull request as ready for review October 22, 2024 18:44
@xylar xylar added sea ice and removed in progress This PR is not ready for review or merging labels Oct 22, 2024
@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

Another Updated Comparison with SOwISC12to30E3r3

Here are the landIceMask fields for the SORRM r4 mesh with MALI (AIS_4to20km) topography:
sorrmr4_land_ice_mask

And the same but SORRM r3 with BedMachine topography from #807:
sorrmr3_land_ice_mask

@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2024

The same as above but zooming in on the Amundsen Sea.

SORRM r4:
sorrmr4_amundsen

SORRM r3:
sorrmr3_amundsen

@cbegeman
Copy link
Collaborator

@xylar have you been looking at all at landIceFloatingFraction?

@xylar xylar requested a review from cbegeman January 15, 2025 19:55
@xylar xylar marked this pull request as ready for review March 31, 2025 15:58
@xylar xylar removed the in progress This PR is not ready for review or merging label Mar 31, 2025
@xylar
Copy link
Collaborator Author

xylar commented Mar 31, 2025

Testing

Tested on an 11-year G-case as described in E3SM-Ocean-Discussion/E3SM#120

@xylar
Copy link
Collaborator Author

xylar commented Mar 31, 2025

@matthewhoffman and @cbegeman, if you could review this along with E3SM-Project/E3SM#7195, that would be wonderful!

@maltrud
Copy link

maltrud commented Mar 31, 2025

the differences in Arctic SSS appear to be due to changing from PHC2.0 to WOA23 for the SSS climatology. here's a plot of annual average SSS (WOA - PHC):
Screenshot 2025-03-31 at 12 21 21 PM

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of testing and visual inspection of these code changes. Thanks @xylar!

@xylar
Copy link
Collaborator Author

xylar commented Mar 31, 2025

@maltrud, I agree, that's what I attribute those changes to, as well. The freshening seems like a move in the wrong direction, right? So something we may want to revisit (separate from this PR).

@xylar
Copy link
Collaborator Author

xylar commented Apr 1, 2025

@matthewhoffman, anything else?

Copy link
Member

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar , no, I don't have any other suggestions.

@xylar
Copy link
Collaborator Author

xylar commented Apr 1, 2025

Great, thanks so much @matthewhoffman and @cbegeman!!!

@xylar xylar merged commit 3b6624a into MPAS-Dev:main Apr 1, 2025
6 checks passed
@xylar xylar deleted the add-mali-topo branch April 1, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E3SM PR finished enhancement New feature or request new mesh An E3SM mesh for special review ocean sea ice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants