-
Notifications
You must be signed in to change notification settings - Fork 40
support running landice/greenland/mesh_gen test case on workstations #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6b3d6a5 to
80676a4
Compare
|
@matthewhoffman Can this be reviewed/merged? It looks like the failing CI tests are unrelated to the changes and caused by package install failures during creation of the python environment. |
|
@cwsmith , yes, I will look at it closer today. Sorry for letting it drop! |
|
No worries. Thank you. |
|
@cwsmith , we'll have to add corresponding changes to |
|
@matthewhoffman Whoops. I didn't consider the other landice meshgen test. Sorry about that. I'll make those changes. |
|
Sorry for the multiple small commits. The pre-commit hook setup/build phase is failing in my environment for some reason... |
|
It looks like the github actions are all passing. Does it or some other CI run the meshgen cases? |
|
No, CI just runs some very low level tests to make sure the conda environment isn't broken. It doesn't run any compass tests. Most tests are too big for CI. |
matthewhoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional changes, @cwsmith !
This PR passes the
parallel_executableto a few functions that were hardcoded to usesrun. With the right input files, this allows testing on workstations with limited memory and cores.Testing was done with subsampled GIS inputs (to 4km, thanks to @matthewhoffman) for the
landice/greenland/mesh_gentest.Checklist
api.rst) has any new or modified class, method and/or functions listed - no changes needed - the doc string forinterp_gridded2maliwas updated incompass/landice/mesh.pyparallel_executablearg is rendered in the htmlE3SM-Projectsubmodule has been updated with relevant E3SM changesMALI-Devsubmodule has been updated with relevant MALI changesTestingin this PR) any testing that was used to verify the changes