Skip to content

Conversation

@cwsmith
Copy link
Contributor

@cwsmith cwsmith commented Jan 31, 2025

This PR passes the parallel_executable to a few functions that were hardcoded to use srun. With the right input files, this allows testing on workstations with limited memory and cores.

Testing was done with subsampled GIS inputs (to 4km, thanks to @matthewhoffman) for the landice/greenland/mesh_gen test.

Checklist

  • User's Guide has been updated - no change needed
  • Developer's Guide has been updated - no change needed
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed - no changes needed - the doc string for interp_gridded2mali was updated in compass/landice/mesh.py
  • Documentation has been built locally and changes look as expected - the new parallel_executable arg is rendered in the html
  • not applicable The E3SM-Project submodule has been updated with relevant E3SM changes
  • not applicable The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • not applicable? New tests have been added to a test suite

@cwsmith cwsmith marked this pull request as ready for review January 31, 2025 15:02
@matthewhoffman matthewhoffman self-requested a review January 31, 2025 16:41
@matthewhoffman matthewhoffman self-assigned this Jan 31, 2025
@cwsmith
Copy link
Contributor Author

cwsmith commented Feb 19, 2025

@matthewhoffman Can this be reviewed/merged? It looks like the failing CI tests are unrelated to the changes and caused by package install failures during creation of the python environment.

@matthewhoffman
Copy link
Member

@cwsmith , yes, I will look at it closer today. Sorry for letting it drop!

@cwsmith
Copy link
Contributor Author

cwsmith commented Feb 20, 2025

No worries. Thank you.

@matthewhoffman
Copy link
Member

@cwsmith , we'll have to add corresponding changes to compass/landice/tests/antarctica/mesh.py (which also calls interp_gridded2mali). I'm happy to do that if you'd prefer not to.

@cwsmith
Copy link
Contributor Author

cwsmith commented Feb 21, 2025

@matthewhoffman Whoops. I didn't consider the other landice meshgen test. Sorry about that. I'll make those changes.

@cwsmith
Copy link
Contributor Author

cwsmith commented Feb 21, 2025

Sorry for the multiple small commits. The pre-commit hook setup/build phase is failing in my environment for some reason...

@cwsmith
Copy link
Contributor Author

cwsmith commented Feb 21, 2025

It looks like the github actions are all passing. Does it or some other CI run the meshgen cases?

@xylar
Copy link
Collaborator

xylar commented Feb 21, 2025

No, CI just runs some very low level tests to make sure the conda environment isn't broken. It doesn't run any compass tests. Most tests are too big for CI.

Copy link
Member

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional changes, @cwsmith !

@matthewhoffman matthewhoffman merged commit 4c27834 into MPAS-Dev:main Feb 22, 2025
6 checks passed
@cwsmith cwsmith deleted the cws/gisCoarseTest branch February 27, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants