Skip to content

add profile to author, crossref and arxiv publications - #197

Merged
LizzAlice merged 2 commits into
mainfrom
add_missing_profiles
Feb 5, 2026
Merged

add profile to author, crossref and arxiv publications#197
LizzAlice merged 2 commits into
mainfrom
add_missing_profiles

Conversation

@LizzAlice

@LizzAlice LizzAlice commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

add profile pages

Summary by CodeRabbit

  • New Features
    • Publications imported from ArXiv and Crossref now include MaRDI publication profile classification.
    • Authors now include MaRDI person profile classification.
    • Enhanced profile tagging improves metadata consistency and discoverability in the knowledge base.

@LizzAlice
LizzAlice requested a review from eloiferrer February 5, 2026 14:27
@coderabbitai

coderabbitai Bot commented Feb 5, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Adds MaRDI profile-type Wikibase claims during entity creation: publication items (arXiv, Crossref) receive "MaRDI publication profile" and author items receive "MaRDI person profile". No control-flow or error-handling changes.

Changes

Cohort / File(s) Summary
Publication Profile Claims
mardi_importer/mardi_importer/arxiv/ArxivPublication.py, mardi_importer/mardi_importer/crossref/CrossrefPublication.py
Insert MaRDI profile type claim with value "MaRDI publication profile" into created publication items (after arXiv P818 and DOI/author claim flows respectively).
Author Profile Claims
mardi_importer/mardi_importer/utils/Author.py
Insert MaRDI profile type claim with value "MaRDI person profile" into created author items (added after arXiv ID assignment).

Sequence Diagram(s)

(omitted — change is limited to adding metadata claims, not multi-component control-flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • eloiferrer
  • rimmoussa

Poem

🐰 I hop and tag each author and page,
A MaRDI ribbon for profile and page,
Publications gleam with a tiny new crest,
Metadata snug in its structured nest,
Hooray — the graph wears its Sunday best! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add profile to author, crossref and arxiv publications' directly and accurately describes the main changes across all three modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add_missing_profiles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@mardi_importer/mardi_importer/crossref/CrossrefPublication.py`:
- Line 350: The fallback branch that creates items when self.title is absent is
missing the MaRDI profile claim; ensure that item.add_claim("MaRDI profile
type", "MaRDI publication profile") is also called for the else/fallback path
where the item is constructed without self.title (i.e., mirror the call
currently inside the block guarded by self.title so both branches add the
profile claim for the created item).

Comment thread mardi_importer/mardi_importer/crossref/CrossrefPublication.py
@LizzAlice
LizzAlice merged commit 1e274d3 into main Feb 5, 2026
2 checks passed
@LizzAlice
LizzAlice deleted the add_missing_profiles branch February 5, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants