add profile to author, crossref and arxiv publications - #197
Conversation
📝 WalkthroughWalkthroughAdds MaRDI profile-type Wikibase claims during entity creation: publication items (arXiv, Crossref) receive "MaRDI publication profile" and author items receive "MaRDI person profile". No control-flow or error-handling changes. Changes
Sequence Diagram(s)(omitted — change is limited to adding metadata claims, not multi-component control-flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@mardi_importer/mardi_importer/crossref/CrossrefPublication.py`:
- Line 350: The fallback branch that creates items when self.title is absent is
missing the MaRDI profile claim; ensure that item.add_claim("MaRDI profile
type", "MaRDI publication profile") is also called for the else/fallback path
where the item is constructed without self.title (i.e., mirror the call
currently inside the block guarded by self.title so both branches add the
profile claim for the created item).
add profile pages
Summary by CodeRabbit