[Windows] Upgrade to ffigen: ^17.0.0 and regenerate bindings#2554
[Windows] Upgrade to ffigen: ^17.0.0 and regenerate bindings#2554Levi-Lesches wants to merge 3 commits intoMaikuB:masterfrom
ffigen: ^17.0.0 and regenerate bindings#2554Conversation
Bumps [ffigen](https://github.com/dart-lang/native/tree/main/pkgs) from 13.0.0 to 17.0.0. - [Release notes](https://github.com/dart-lang/native/releases) - [Commits](https://github.com/dart-lang/native/commits/ffigen-v17.0.0/pkgs) --- updated-dependencies: - dependency-name: ffigen dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
From the CI logs for Flutter 3.22: Note: meta is pinned to version 1.12.0 by flutter from the flutter SDK.
See https://dart.dev/go/sdk-version-pinning for details.
Because ffigen >=17.0.0 depends on dart_style ^3.0.0 which depends on analyzer >=6.5.0 <8.0.0, ffigen >=17.0.0 requires analyzer >=6.5.0 <8.0.0.
Because analyzer >=6.5.1 depends on meta ^1.15.0 and analyzer >=6.5.0 <6.5.1 depends on meta ^1.14.0, analyzer >=6.5.0 requires meta ^1.14.0.
Thus, ffigen >=17.0.0 requires meta ^1.14.0.
And because every version of flutter from sdk depends on meta 1.12.0, ffigen >=17.0.0 is incompatible with flutter from sdk.
So, because flutter_local_notifications_windows depends on both flutter from sdk and ffigen ^17.0.0, version solving failed.
You can try the following suggestion to make the pubspec resolve:
* Consider downgrading your constraint on ffigen: flutter pub add dev:ffigen:^15.0.0I'd say let's close this for now and re-open #2495 as a draft for when we bump Flutter again. |
|
Yes this should be closed. It's the same issue as when you raised #2495 and was closed. On a related note, I believe you should have the ability to also your own PRs too? I recall seeing others accidentally raising PRs to this repo and then closed it themselves |
|
I do, I was just trying to get your attention to re-open #2495 as a draft because it will, at some point, become viable again. |
|
It won't make sense to keep even as a draft either given it had a specific purpose around bumping to 16. It was closed due to having conflicts that would've remained even with specifying 17.0.0. Whilst I've not checked what it depends on it, in generally it's more likely the version conflict would've worsened as major version bumps may come with a bump in dependencies. It would make more sense to have a separate PR at the time of that the minimum Flutter version for this plugin is bumped as opposed to leaving a draft PR around. I will generally check what can be reasonably bumped as part of this exercise as well |
|
I've bumped the minimum Flutter version now. Let me know if you have capacity to revisit soon as if you won't get to then I'll make the changes and am happy to credit you in changelog |
2 participants
Closes #2553 and #2495