Skip to content

Adding BERT score [WIP]#76

Open
ghost wants to merge 1 commit intomasterfrom
unknown repository
Open

Adding BERT score [WIP]#76
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 6, 2019

For #75

BERT score added, but not tested yet.

This is still WIP, I don't have a Linux instance with GPU to test it yet.

Dependencies :

  • pytorch
  • bert-score

TODO

  • Check if the added test is running fine
  • Update other tests
  • Update README with new dependencies

'Bleu_1', 'Bleu_2', 'Bleu_3', 'Bleu_4',
'METEOR',
'ROUGE_L',
'BERT_score'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comma missing at the end of the line.

@juharris
Copy link
Copy Markdown
Contributor

juharris commented Jul 8, 2019

Thank you for your contribution!

Would you add the new requirements to requirements_py2.txt and requirements.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants