-
Notifications
You must be signed in to change notification settings - Fork 126
[WIP] Set manager_ref to file path for embedded ConfigurationScripts #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] Set manager_ref to file path for embedded ConfigurationScripts #711
Conversation
The manager_ref is typically used to track the "unique" attribute of an object, for ansible_tower/awx the manager_ref is the job_template.id but for embedded_ansible the manager_ref was nil and the name was set to the file path. Embedded Workflows copied this behavior, but it would be preferable to match how the "external" automation managers operate and also open up the `:name` column for a more user friendly name.
5ee9c1d to
3e33249
Compare
|
Checked commit agrare@3e33249 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
5 similar comments
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
The manager_ref is typically used to track the "unique" attribute of an object, for ansible_tower/awx the manager_ref is the job_template.id but for embedded_ansible the manager_ref was nil and the name was set to the file path.
Embedded Workflows copied this behavior, but it would be preferable to match how the "external" automation managers operate and also open up the
:namecolumn for a more user friendly name.