[WIP] - Remove unused shared packages - #10252
Draft
asirvadAbrahamVarghese wants to merge 1 commit into
Draft
Conversation
|
|
||
| const sharedPackages = [ | ||
| '@carbon/react', | ||
| 'angular', |
Contributor
Author
There was a problem hiding this comment.
I don’t see angular being used with these plugins (if any components are added in the future, I assume they will be react) so I assume this also is no longer needed. Let me know if that's not the case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10219 (Should be merged only after ManageIQ/manageiq-providers-redfish#247)
prop-types has been replaced by TypeScript, and connect from react-redux has been replaced with redux hooks in these PRs:
Therefore, these packages are no longer required as shared dependencies.