Update bootstrap

[GilbertCherrie]

Update Bootstrap to 5. Also added popper.js since it is a dependency of bootstrap 5.

[GilbertCherrie]

@Fryguy I fixed the conflicts here if you can review again when you have time

[Fryguy]

Why is popper added directly. That is, won't it just come in naturally as a dependency?

[GilbertCherrie]

Why is popper added directly. That is, won't it just come in naturally as a dependency?

When I try to run npm start without the popper package in the package.json it throws this error. I'm assuming because it's a peer dependency we need to actually declare it in the package.json.

[Fryguy]

ok, so from what I understand - the better way to declare missing peer dependencies is to use packageExtensions. This allows you to essentially force bootstrap to pull in the dependency (and we don't have to declare it as "our" dependency.

So in the .yarnrc.yml you would add something like:

packageExtensions:
  "bootstrap@*":
    dependencies:
      "popper.js": "~1.16.1"

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[GilbertCherrie]

@Fryguy I fixed the dependency issue if you can review this again when you get a chance.

[GilbertCherrie]

@Fryguy I think this pr is good to merge if you can review

[GilbertCherrie]

@elsamaryv please review

[Fryguy]

@GilbertCherrie This went into conflict

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[GilbertCherrie]

@Fryguy I updated the pr if you can take another look

[miq-bot]

Checked commit GilbertCherrie@4059a9d with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
1 file checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).