Recognize WIP after other title tags - #974
Merged
Merged
Conversation
missusk
marked this pull request as ready for review
August 26, 2026 08:14
Member
|
Nice fix! Thank you @missusk! |
Fryguy
reviewed
Aug 26, 2026
Fryguy
approved these changes
Aug 26, 2026
Fryguy
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the existing leading title-tag parser when adding or removing the
wiplabel. This recognizesWIPafter tags such asRFR, avoids adding a duplicate[WIP], and preserves other leading tags when WIP is removed.The regression spec fails on
master: adding the label changes[RFR] [WIP] Fix titleto[WIP] [RFR] [WIP] Fix title, while removing the label leaves the title unchanged.Fixes #334
Tested:
bundle exec rspec spec/lib/github_service/issue_spec.rb spec/models/branch_spec.rb spec/workers/pull_request_monitor_handlers/wip_labeler_spec.rb(37 examples, 0 failures)bundle exec rake(365 examples, 0 failureson Ruby 3.3.10/Linux)