Skip to content

Conversation

ottok
Copy link
Contributor

@ottok ottok commented Aug 26, 2025

Description

Ask users to give MariaDB a star by having an extra line in the MariaDB client prompt:

Welcome to the MariaDB monitor.  Commands end with ; or \g.
Your MariaDB connection id is 33
Server version: 12.2.0-MariaDB-1:12.2.0 mariadb.org binary distribution

Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.

Please help get to 10k stars at https://github.com/MariaDB/Server
Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

MariaDB [(none)]>

Additionally, have this extra line in server logs:

[Note] Please help get to 10k stars at https://github.com/MariaDB/server

This change is done in a way that it is easy to cherry-pick to older releases, and the text can later be changed to promote something else once MariaDB has surpassed MySQL in GitHub stars.

Release Notes

  • none

How can this PR be tested?

  • Start the server, look at logs
  • Connect with the client to any server, observe the output

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@ottok ottok force-pushed the github-stars-promotion branch from ed0655e to 6908f9e Compare August 26, 2025 06:17
Ask users to give MariaDB a star by having an extra line in the MariaDB
client prompt:

    Welcome to the MariaDB monitor.  Commands end with ; or \g.
    Your MariaDB connection id is 33
    Server version: 12.2.0-MariaDB-1:12.2.0 mariadb.org binary distribution

    Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.

    Please help get to 10k stars at https://github.com/MariaDB/Server
    Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

    MariaDB [(none)]>

Additionally, have this extra line in server logs:

    [Note] Please help get to 10k stars at https://github.com/MariaDB/server

This change is done in a way that it is easy to cherry-pick to older
releases, and the text can later be changed to promote something else
once MariaDB has surpassed MySQL in GitHub stars.

Test file updated with:
nano --noconvert --nonewlines mysql-test/main/mysql-interactive.result
@ottok ottok force-pushed the github-stars-promotion branch from 6908f9e to eb8609c Compare August 26, 2025 06:37
@ottok
Copy link
Contributor Author

ottok commented Aug 26, 2025

Failure in test buildbot/amd64-ubuntu-2204-debug-ps seems unrelated to this PR:

plugins.server_audit                     w26 [ fail ]
        Test ended at 2025-08-26 06:46:53
CURRENT_TEST: plugins.server_audit
--- /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/plugins/r/server_audit.result	2025-08-26 06:42:01.000000000 +0000
+++ /home/buildbot/amd64-ubuntu-2204-debug-ps/build/mysql-test/suite/plugins/r/server_audit.reject	2025-08-26 06:46:53.270007402 +0000
@@ -538,7 +538,6 @@
 TIME,HOSTNAME,ssl_user1,localhost:PORT,ID,0,CONNECT,sa_db,TLS_VERSION,0
 TIME,HOSTNAME,ssl_user1,localhost:PORT,ID,ID,QUERY,sa_db,'SHOW STATUS LIKE \'Ssl_version\'',0
 TIME,HOSTNAME,ssl_user1,localhost:PORT,ID,ID,QUERY,sa_db,'select variable_value > \'\' as \'have_ssl\' from information_schema.session_status where variable_name=\'ssl_cipher\'',0
-TIME,HOSTNAME,ssl_user1,localhost:PORT,ID,0,DISCONNECT,sa_db,TLS_VERSION,0
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,WRITE,mysql,db,
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,WRITE,mysql,tables_priv,
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,WRITE,mysql,columns_priv,
@@ -548,6 +547,7 @@
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,WRITE,mysql,global_priv,
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,QUERY,sa_db,'DROP USER ssl_user1@localhost',0
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,QUERY,sa_db,'set global serv',0
+TIME,HOSTNAME,ssl_user1,localhost:PORT,ID,0,DISCONNECT,sa_db,TLS_VERSION,0
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,QUERY,sa_db,'select (1), (2)',0
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,QUERY,sa_db,'select \'A\', ',0
 TIME,HOSTNAME,root,localhost:PORT,ID,ID,QUERY,sa_db,'set global server_audit_query_log_limit= 1024',0
Result content mismatch

@ParadoxV5
Copy link
Contributor

Plug? It’s not always welcomed.1
Not to mention the potential of a “we already hit 10K Stars” bug in the future.

Failure in test buildbot/amd64-ubuntu-2204-debug-ps seems unrelated to this PR:

It was recently filed at MDEV-37501.

Footnotes

  1. https://github.com/zloirock/core-js/blob/master/docs/2023-02-14-so-whats-next.md#fundraising

@ParadoxV5 ParadoxV5 requested a review from vuvova August 26, 2025 17:57
@ottok
Copy link
Contributor Author

ottok commented Aug 26, 2025

Plug? It’s not always welcomed. Not to mention the potential of a “we already hit 10K Stars” bug in the future.

Depends on the plug. Sometimes it is welcomed, like in the case of Thunderbird getting a new life once they started appealing to their users. Going past 10k stars is fine, the more the better. I think this type of request for support/visibility is a good way to appeal to users and show one easy way they can support the project.

@Barmy
Copy link

Barmy commented Aug 27, 2025

I just saw it after launching the client cli and I came over to give my star

@svoj svoj added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Aug 27, 2025
@notr1ch
Copy link

notr1ch commented Sep 1, 2025

I was surprised to see this showing up in the latest LTS release, it turns out the Debian package maintainer added this as a patch to the Debian package for some reason. I expect GitHub star chasing from My First Node.js package, not a professional RDBMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.
Development

Successfully merging this pull request may close these issues.

5 participants