Remove mysqld_error_find_printf_error_used
#4277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preprocessor switch is never defined. The commit history tells that it is for a `create_mysqld_error_find_printf_error` script, of which I did not find any public mention. I found one conversation from searching our private Corporation Slack, where Monty shares that he used it to generate `include/ mysqld_error_find_printf_error.h` that surfaces erroneous `printf`s. In any case, now that MDEV-21978 (#3360) has (re)enabled `-Wformat` that activates `printf` checks built into the compilers, we can use their attributes (e.g., GCC: `__attribute__((format(printf, …)))`) and should no longer require preprocessing replacements.
vuvova
requested changes
Sep 13, 2025
There was a problem hiding this comment.
__attribute__((format(printf, …)))) is not quite the same, a compiler cannot check my_error() parameters, because it doesn't know the format string, it's loaded at run time.
that manual process with the create_mysqld_error_find_printf_error script is, of course, totally unmaintainable, I am not sure it was ever run more than once. But simply removing it doesn't solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-______Description
This preprocessor switch is never defined.
The commit history tells that it is for a
create_mysqld_error_find_printf_errorscript, of which I did not find any public mention.I found one conversation from searching our private Corporation Slack, where Monty shares that he used it to generate
include/mysqld_error_find_printf_error.hthat surfaces erroneousprintfs.In any case, now that MDEV-21978 (#3360) has (re)enabled
-Wformatthat activatesprintfchecks built into the compilers, we can use their attributes (e.g., GCC:__attribute__((format(printf, …)))) and should no longer require preprocessing replacements.Release Notes
N/A
(Brag about dead code removal if you like.)
How can this PR be tested?
Can you please publish your
/tmp/my/scripts/create_mysqld_error_find_printf_error, Monty the Great?PR quality check
mainbranch.This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.