Escape the $
s in include/show_slave_status.inc
’s error messages
#4285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-______Description
--die
performs variable substitution like--echo
does, so the variable names were parsed rather than mentioned verbatim.Before Patch (Erroneous)
After Patch (Intended)
Release Notes
N/A
Unless there are users who write their own Replication MTR tests.
How can this PR be tested?
We are about as reliant on
include/*.inc
files as actual MTR commands.This means the
include/*.inc
s are as eligible for unit testing as MTR commands are, right?PR quality check
This is a new feature or a refactoring, and the PR is based against themain
branch.I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.