Wrap parsing error to allow caller to discern why things failed#220
Open
crozzy wants to merge 1 commit intoMasterminds:masterfrom
Open
Wrap parsing error to allow caller to discern why things failed#220crozzy wants to merge 1 commit intoMasterminds:masterfrom
crozzy wants to merge 1 commit intoMasterminds:masterfrom
Conversation
Author
|
I suppose you could also wrap the err returned with |
mattfarina
requested changes
Nov 19, 2024
Member
mattfarina
left a comment
mattfarina
left a comment
There was a problem hiding this comment.
Switching to ErrSegmentUnparsable would remove details on what part of the version failed to parse. It would be nice to keep that.
Switching to %w is something I would be immediately open to.
crozzy
force-pushed
the
add-new-error-type
branch
from
a24cef3 to
bb7a120
Compare
crozzy
changed the title
It's hard to reason with errors when `strconv.ParseUint` fails as the returned error is untyped. This change wraps the parsing error. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
add-new-error-type
branch
from
bb7a120 to
b40b53a
Compare
Author
|
Updated, one thing, I lower-cased those error strings to adhere to https://go.dev/wiki/CodeReviewComments#error-strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to reason with errors when
strconv.ParseUintfails as the returned error is untyped. This change introduces a new error that is returned if the int parsing fails.