Optimize kixi.stats.core/proportion

[alexander-yakushev]

Current implementation uses vectors to keep the transitive state which allocates new vectors on each step. The proposed implementation uses a mutable array instead. Volatile is added to ensure that changes are visible between threads if somebody decides to uses this reducing function in a multi-threaded context.

[henrygarner]

Thanks for this! I'm seeing a failing proportion-test when running locally: java.lang.ClassCastException: class clojure.lang.Volatile cannot be cast to class clojure.lang.IAtom

I've updated main to bump a deprecated actions cache version, so test actions should run remotely if you rebase onto main and force push.

[alexander-yakushev]

Thank you! I've fixed the bad line and rebased onto the upstream main but tests still don't run for some reason.

[henrygarner]

Apologies, I thought the tests would re-run for you!

We still have a failing proportion-test:

clj:

ERROR in (proportion-test) (core.clj:2315)
expected: (=ish (transduce identity (kixi/proportion neg?) [1 -1 3 5]) 0.25)
  actual: java.lang.ClassCastException: class [J cannot be cast to class java.util.concurrent.Future ([J and java.util.concurrent.Future are in module java.base of loader 'bootstrap')

cljs:

ERROR in (proportion-test) (kixi/stats/core_test.cljc:648:7)
expected: (=ish (transduce identity (kixi/proportion neg?) [1 -1 3 5]) 0.25)
  actual: #object[Error Error: No protocol method IDeref.-deref defined for type array: ,1]

[alexander-yakushev]

Sorry about that! It should pass the tests now.