Turn normalize into unary function #33805
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged docs for this (#33785) which will need to be updated now. |
Normalize is a special function in that its second argument is a keyword instead of an expression. Move from a runtime string dispatch to determining the correct implementation at plan time. A strangeness this introduces is that there are a bunch of functions `normalize_*` that do not directly correspond to a function the user can type. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
normalize_unary
branch
from
282ce65 to
c98bfe3
Compare
I realized while sitting and staring out a window yesterday that of course the docs would not need to be updated, since the user-facing interface does not change. |
@antiguru can you just say a word about the motivation? Just for clarity/posterity's sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize is a special function in that its second argument is a keyword instead of an expression. Move from a runtime string dispatch to determining the correct implementation at plan time. A strangeness this introduces is that there are a bunch of functions
normalize_*that do not directly correspond to a function the user can type.