Put COUNTER, DATUMS load gen sources behind feature flag
#33847
Conversation
petrosagg
force-pushed
the
feature-flag-loadgen
branch
3 times, most recently
from
f4cd022 to
4a64c73
Compare
| 'CREATE SOURCE' ('IF NOT EXISTS')? src_name | ||
| ('IN CLUSTER' cluster_name)? | ||
| 'FROM LOAD GENERATOR' ('AUCTION' | 'COUNTER' | 'MARKETING' | 'TPCH' | 'KEY VALUE') | ||
| 'FROM LOAD GENERATOR' ('AUCTION' | 'MARKETING' | 'TPCH' | 'KEY VALUE') |
There was a problem hiding this comment.
Did you want to also remove KEY VALUE?
There was a problem hiding this comment.
Also the relevant options from the syntax diagram (e.g., VALUE SIZE)
There was a problem hiding this comment.
Yeah, it's an internal-only type that is also not used in many places. I'll probably delete it in a subsequent PR
There was a problem hiding this comment.
Oh, you mean that I forgot to do it. Yes, you're absolutely right. Will remove now
| DROP MATERIALIZED VIEW IF EXISTS counter_sum; | ||
| DROP SOURCE IF EXISTS counter; | ||
| DROP MATERIALIZED VIEW IF EXISTS amount_sum; | ||
| DROP SOURCE IF EXISTS auction; |
There was a problem hiding this comment.
CASCADE for dropping auction?
We will eventually phase out these load generators so for now make sure no one relies on them except our tests. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
feature-flag-loadgen
branch
from
4a64c73 to
85df858
Compare
| DROP MATERIALIZED VIEW IF EXISTS counter_sum; | ||
| DROP SOURCE IF EXISTS counter; | ||
| DROP MATERIALIZED VIEW IF EXISTS amount_sum; | ||
| DROP SOURCE IF EXISTS amount; |
There was a problem hiding this comment.
Heh ... DROP SOURCE IF EXISTS auction CASCADE;
| DROP MATERIALIZED VIEW IF EXISTS counter_sum; | ||
| DROP SOURCE IF EXISTS counter; | ||
| DROP MATERIALIZED VIEW IF EXISTS ammount_sum; | ||
| DROP SOURCE IF EXISTS amount; |
There was a problem hiding this comment.
same. DROP SOURCE IF EXISTS auction CASCADE;
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
feature-flag-loadgen
branch
from
85df858 to
63b90d8
Compare
|
@kay-kim sorry about those typos! It should be good to go now |
3 participants
Motivation
The intent is to remove these load generators completely but at the moment we use them in our internal test suite quite extensively. Putting them behind a feature flag ensures we won't get any external users depending on them.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.