fix(apple-ui): HIG polish — brand logo + DetailView + semantic backgrounds sweep - #5
Merged
Merged
Conversation
Replace the plain "Shares" large title with BrandLockup in the principal toolbar slot — the App Store / iMessage / Instagram pattern. Logo stays visible on every scroll position and reinforces brand identity on the primary screen. Switched navigationBarTitleDisplayMode to .inline so the principal slot renders without a stacked title.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 33 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesmo tratamento que aplicamos em HistoryView: List(.insetGrouped), BrandLockup no toolbar .principal, semantic colors em vez de tintas hard-coded. - Background: .systemGroupedBackground (dark-mode-aware) substitui o BrandPalette.friendlyGround cream hard-coded que o user reclamou. - Removido: nav bar custom, floating action dock com gradient fade, countdown hero card tingido por tier, stat tiles, extendRow placeholder, ellipsis menu placeholder. - Adicionado: sections HIG (Hero edge-to-edge, Link com ShareLink + Link-to-Safari + textSelection, Details via LabeledContent, Files bundle-aware, Actions com Revoke destrutivo no final). - Countdown live via TimelineView envolvendo a List; ring + countdown em monospacedDigit; status chip (dot + label) discreto. - Bundle: nova seção "N files" listando bundledAssets ordenados por displayOrder — antes a tela não expunha os filhos. - Copy button: .bordered/.small inline (em vez de pill magenta) pareado com textSelection(.enabled) pro URL longo.
MatheusKindrazki
changed the title
Sweep completo de background colors — substitui tokens cream hard-coded (BrandPalette.friendlyGround/canvas/paper/surface0/surface1 e FriendlyPalette equivalentes) por semantic colors nativas, dark-mode-aware: - Scene top-level / Form / List containers → Color(.systemBackground) ou .systemGroupedBackground. - Hero cards / destacados → Color(.secondarySystemBackground). - macOS → Color(nsColor: .windowBackgroundColor / .controlBackgroundColor / .underPageBackgroundColor). - Share Extension → mesmo padrão iOS (37 call sites em ShareRootView). - Text tokens (text/textDim/textFaint/line/lineStrong) → .label / .secondaryLabel / .tertiaryLabel / .separator. Accents preservados (BrandPalette.accentHot, amberAccent, violetAccent, urgencyCritical, arc, successGreen) — CTAs, upsell cards do paywall, urgency rings, sign-in bloom e splash glow continuam branded. Text dentro de botões accent mantém FriendlyPalette.text(.light) pra contraste fixo. SplashView ambient glow intencional preservado. BrandLockup, ScreenshotBanner, HistoryView e DetailView intactos.
MatheusKindrazki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Três fixes de polimento visual Apple HIG num único build:
1. BrandLockup logo (HistoryView)
navigationTitle("Shares")→BrandLockupno toolbar.principal. Padrão App Store/iMessage.2. DetailView HIG-native redesign
List(.insetGrouped)+BrandLockupno principal.BrandPalette.friendlyGround) →.systemGroupedBackground(dark-mode-aware).TimelineViewenvolvendo a List pra countdown live sem recompor tudo.3. Background sweep — todas as telas
Substituí tokens cream hard-coded (
BrandPalette.friendly{Ground,Canvas,Paper,Surface0,Surface1}e equivalentes) por semantic colors nativas em:SplashView,OnboardingView,SettingsView,SignInViewPaywallView+PaywallTierCardMacCompanionView+MacMenuBarView(NSColor equivalents)RootView(dispatch platform-aware)ShareRootView(37 call sites no Share Extension)Accents preservados: CTAs amber/violet, urgency rings, paywall upsell stroke, sign-in bloom, splash glow.
Test plan
** BUILD SUCCEEDED **)🤖 Generated with Claude Code