Skip to content

Support changing the baseURL for ProxySupport#229

Merged
rocky merged 5 commits intoMathics3:masterfrom
adamboutcher:ProxySupport
Mar 7, 2025
Merged

Support changing the baseURL for ProxySupport#229
rocky merged 5 commits intoMathics3:masterfrom
adamboutcher:ProxySupport

Conversation

@adamboutcher
Copy link
Copy Markdown
Contributor

See issue - #228

This (probably terrible) change will allow you to use the env variable "MATHICS_DJANGO_URL" to support serving the files from a different BASE_URL.

This meant we could serve the application via a proxy, we were using "Open OnDemand" with a proxy configuration we couldn't change and also dynamic proxy addresses.

@adamboutcher
Copy link
Copy Markdown
Contributor Author

adamboutcher commented Mar 3, 2025

The suggested change worked.

This all seems to work without applying a URL (or at least with my basic testing of pressing the examples button).

Only caveat is that the URL in the browser requires the trailing slash but that shouldn't be included in the URL variable.

@rocky
Copy link
Copy Markdown
Member

rocky commented Mar 6, 2025

@adamboutcher the changes are fine but would you please run

pip install black
black mathics_django/urls.py mathics_django/settings.py

Thanks.

@adamboutcher
Copy link
Copy Markdown
Contributor Author

@adamboutcher the changes are fine but would you please run

pip install black
black mathics_django/urls.py mathics_django/settings.py

Thanks.

Done.

@rocky rocky merged commit 530b794 into Mathics3:master Mar 7, 2025
9 checks passed
@adamboutcher adamboutcher mentioned this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants