Date search #12
Open
Date search #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two date fields to the search options, one "from" and one "until". These will limit the results to those created or edited between these dates (if specified). AFAICT, the date input should be pretty well supported in browsers these days.
The "until" date is not inclusive, meaning that only entries from before that date are included. Not sure if that is intuitive, it was just the simplest to implement.
Also, there might be some complexity around timestamps, I've tried to address it but it's not well tested.
As a bonus, I've fixed the test suite, and there's now a "make test" target (assumes "pytest" is installed).