Fix for overhauling to storage buildings. #67
Open
simplyWiri wants to merge 1 commit intoMehni:masterfrom
Open
Fix for overhauling to storage buildings. #67simplyWiri wants to merge 1 commit intoMehni:masterfrom
simplyWiri wants to merge 1 commit intoMehni:masterfrom
Conversation
e5651f5 to
e302876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the situation where we have a storage building which accepts:
With the previous system, if we went to haul some
Meat- to this storage cell - we would get the maximum capacity for the cell, as(75-53) + (75-33) = 64, and we would look for ~64 meat to haul. This is incorrect behavour, as we can only haul 22 meat to this storage item.This gets worse when you consider cases where we have, for example:
In this case, if we query for meat - we have a capacity of ~149 - if we only have 74 meat, - then consider hauling some apparel (or any other item which stacks to one) - we will then attempt to haul
75items of apparel to a single cell.