-
Notifications
You must be signed in to change notification settings - Fork 8
pnpm #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| steps: | ||
| - uses: actions/checkout@main | ||
| name: Checkout | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy jobs removed without replacement, breaking deployments
The deploy job now only checks out the repository but performs no actual deployment. The deploy-to-swarm action was removed but not replaced with an alternative deployment mechanism. When code is merged to master, the deploy job will complete successfully without deploying anything to production.
Additional Locations (1)
pnpm-workspace.yaml
Outdated
| - packages/* | ||
| - apps/* | ||
| catalog: | ||
| "@adonisjs/assembler": ^5.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А разве это не зависимость только одного сервиса?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| steps: | ||
| - uses: actions/checkout@main | ||
| name: Checkout | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy jobs removed, workflows do nothing
High Severity
The deploy jobs in both blog-deploy.yml and gamehub-deploy.yml had their deployment steps completely removed. The jobs now only perform a checkout without any actual deployment action. When these workflows run, they will appear to succeed but won't deploy anything to production. The deploy-to-swarm action calls were removed without replacement, leaving the deploy jobs empty.
Additional Locations (1)
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ pnpm ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR trigger accidentally added to scheduled workflow
Low Severity
A pull_request trigger for the pnpm branch was added to the ligretto-schedule-e2e.yml workflow. This workflow is meant to run on a schedule (daily cron) and manual dispatch, not on pull requests. This appears to be temporary testing code that was accidentally included and will remain after the PR is merged.
Note
Migrates the monorepo to pnpm and aligns build, CI, and deployment pipelines.
corepack enable, cachedpnpm install,pnpm next build,pnpm deploy), adjust runtime ENTRYPOINTS and copy.next/static.npmrc(engine, hoist),pnpm-workspace.yamlwith shared catalog, updatepackage.jsonengines/scriptspnpm/action-setup, pnpm cache, pnpm scripts) and watchpnpm-lock.yaml; expand deploy branches to includepnpm.gitignore,.eslintignore, VSCode settings), README instructions switched topnpm installWritten by Cursor Bugbot for commit aa8c739. This will update automatically on new commits. Configure here.