Fix crash when adding map sketches on older QGIS release and add a test case

[ValentinBuira]

Fix crash when adding a map sketches layer because we can't use the new fancy enum in older QGIS release.

Also add a test case for this

[JanCaha]

Not sure if we want to default to older enum type by default or if we want have something like:

 if Qgis.versionInt() >= 34000:
        symbol_layer.setDataDefinedProperty(QgsSymbolLayer.Property.StrokeColor, QgsProperty.fromExpression('"color"'))
    else:
        symbol_layer.setDataDefinedProperty(QgsSymbolLayer.PropertyStrokeColor, QgsProperty.fromExpression('"color"'))

This should work with both older versions of QGIS and also in the future if the QgsSymbolLayer.PropertyStrokeColor gets ever removed. Not sure if we have guideline for something like this.

Besides that, it looks all good.

[JanCaha]

Not exactly sure, why the test is failing. It should work the code seems to be fine ...

[ValentinBuira]

This should work with both older versions of QGIS and also in the future if the QgsSymbolLayer.PropertyStrokeColor gets ever removed. Not sure if we have guideline for something like this.

I don't think it will be ever removed with the don't break API rule in QGIS, but the new entries to the enum will be accessed with QgsSymbolLayer.Property.NewPropertyName

[JanCaha]

Ok, lets leave it as it is.

Just fix the test then ;-)