Add activity feed API #1081
Add activity feed API #1081
Conversation
WalkthroughIntroduces a new Express HTTP server at graphite-demo/server.js. It starts on port 3000, defines an in-memory activityFeed with three items, and exposes a single GET /feed endpoint that returns the array as JSON. Logs a startup message. No additional routes, errors, or exports. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant App as Express App
participant Route as GET /feed Handler
Client->>App: HTTP GET /feed
App->>Route: Route dispatch
Note over Route: Read in-memory activityFeed
Route-->>App: res.json(activityFeed)
App-->>Client: 200 OK + JSON array
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@claude review this pull request and do a detailed analysis and fix this if the existing code doesn't have the solution implemented. Making sure it has backward compatibility, no existing features removed. After making those changes, again review the applied changes. Use @web to search if you dont know any information or to find the latest documentation or to find the latest version. Run the code if you think you need to run it to test it. Minimal code change to start with if required any changes. MAINLY IT SHOULD NOT IMPACT ON THE CURRENT SPEED OF EXECUTION of existing features, not increasing the overhead. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
graphite-demo/server.js (4)
1-3: Use env-configurable port and hide Express fingerprint
- Binding to a fixed port can clash with other services or PaaS environments that inject PORT.
- Disabling the X-Powered-By header avoids leaking the Express stack in responses.
Apply this diff:
const express = require('express'); const app = express(); -const port = 3000; +// Hide framework signature +app.disable('x-powered-by'); +// Prefer env PORT with a dev fallback +const port = process.env.PORT || 3000;
24-26: Add minimal pagination + no-store cache header (backward-compatible)Keeps default behavior the same but allows clients to request a limited number of items and ensures clients don’t cache dynamic feeds.
-app.get('/feed', (req, res) => { - res.json(activityFeed); -}); +app.get('/feed', (req, res) => { + const limitParam = Number.parseInt(req.query.limit ?? '', 10); + const limit = + Number.isFinite(limitParam) && limitParam > 0 + ? Math.min(limitParam, activityFeed.length) + : activityFeed.length; + const items = activityFeed.slice(0, limit); + res.set('Cache-Control', 'no-store'); + res.json(items); +});
28-30: Guard server startup and export app for tests/reuseWrapping listen avoids side-effects on import and enables integration tests or embedding in a larger app.
-app.listen(port, () => { - console.log(`Server running on port ${port}`); -}); +if (require.main === module) { + app.listen(port, () => { + console.log(`Server running on port ${port}`); + }); +} + +module.exports = app;
5-22: Optional: enrich feed items with metadata (type, createdAt) for clientsAdding a minimal schema (e.g., type and createdAt ISO timestamp) helps clients sort/filter and render appropriately without guessing. Not required for this PR, but consider for follow-ups if this is more than a demo.
I can provide a follow-up patch adding type/createdAt while preserving current fields and order.
Do you want me to draft that?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
graphite-demo/server.js(1 hunks)
| const express = require('express'); | ||
| const app = express(); | ||
| const port = 3000; | ||
|
|
||
| // Fake data for the activity feed | ||
| const activityFeed = [ | ||
| { | ||
| id: 1000, | ||
| title: 'New Photo Uploaded', | ||
| body: 'Alice uploaded a new photo to her album.' | ||
| }, | ||
| { | ||
| id: 2000, | ||
| title: 'Comment on Post', | ||
| body: "Bob commented on Charlie's post." | ||
| }, | ||
| { | ||
| id: 13, | ||
| title: 'Status Update', | ||
| body: 'Charlie updated their status: "Excited about the new project!"' | ||
| } | ||
| ]; | ||
|
|
||
| app.get('/feed', (req, res) => { | ||
| res.json(activityFeed); | ||
| }); | ||
|
|
||
| app.listen(port, () => { | ||
| console.log(`Server running on port ${port}`); | ||
| }); |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify repo dependencies and potential port conflicts
Ensure express is declared and check for other listeners on port 3000 to avoid collisions when running the demo.
Run this script from the repo root:
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "== Checking for package.json files and express dependency =="
fd -a -t f -g package.json | while read -r pkg; do
echo "---- $pkg ----"
if jq -e '.dependencies.express // .devDependencies.express' "$pkg" >/dev/null 2>&1; then
echo "express declared:" "$(jq -r '.dependencies.express // .devDependencies.express' "$pkg")"
else
echo "express not declared in this package.json"
fi
done
echo
echo "== Searching for other servers that call listen(...) or use port 3000 =="
# Look for listen() calls (avoid node_modules)
rg -n -C2 -g '!**/node_modules/**' -P '\blisten\s*\(\s*(process\.env\.PORT|\d+)' || true
# Explicit port 3000 occurrences (outside node_modules)
rg -n -C2 -g '!**/node_modules/**' -P '\b3000\b' || true
echo
echo "== If express is missing, install with =="
echo "npm install express"Length of output: 58521
Ensure Express is declared and make the port configurable to avoid collisions
• Add an explicit package.json in graphite-demo/ (or update the existing one) with Express as a dependency, e.g.:
{
"name": "graphite-demo",
"version": "1.0.0",
"dependencies": {
"express": "^4.18.2"
}
}• In graphite-demo/server.js, replace the hard-coded port with an environment-override:
- const port = 3000;
+ const port = process.env.PORT || 3000;• Note that other components (e.g. Langtrace agents in src/praisonai-agents) default to localhost:3000. If you run both services locally, pick different ports or override via PORT to prevent conflicts.
🤖 Prompt for AI Agents
In graphite-demo/server.js lines 1 to 30, make the port configurable and ensure
express is declared properly: keep the existing require('express') but replace
the hard-coded port with a value read from process.env.PORT (e.g. const port =
process.env.PORT || 3000) so callers can override it to avoid collisions;
additionally add or update graphite-demo/package.json at the project root to
declare express as a dependency (name, version and "express": "^4.18.2") so npm
install will install Express.
PR Type
Enhancement
Description
Add Express.js server with activity feed endpoint
Create
/feedAPI route returning JSON dataInclude sample activity data for testing
Diagram Walkthrough
File Walkthrough
server.js
Create Express server with activity feed APIgraphite-demo/server.js
/feedGET endpoint returning activity dataSummary by CodeRabbit