Migrate jules pftparm metadata to jules shared#205
Open
Maggie (maggiehendry) wants to merge 52 commits intoMetOffice:mainfrom
Open
Migrate jules pftparm metadata to jules shared#205Maggie (maggiehendry) wants to merge 52 commits intoMetOffice:mainfrom
Maggie (maggiehendry) wants to merge 52 commits intoMetOffice:mainfrom
Conversation
…del-environment** - As a result of the way lfric_coupled imports the component config files `jules_model_environment` cannot exist in two different components. - Added for now with "_lfric" appended to namelist to avoid overwiting Rivers config. - `lsm_id` has not been shared as no point until "_lfric" can be removed. - Trigger list added with "not_lfric" as a result of enumeration. - `jules_surface` migrated to **lfric-jules-shared/jules-surface**. - Switches not available to LFRic triggered off (`l_jules_parent`) and made unavailable via code. - **jules-lfric** contains related LFRic specific amendments to shared metadata.
…odel_environment-remainder-of-jules_surface-to-jules-shared
…t-remainder-of-jules_surface-to-jules-shared
…t-remainder-of-jules_surface-to-jules-shared
…surface-to-jules-shared' of github.com:maggiehendry/lfric_apps into 146-migrate-jules_model_environment-remainder-of-jules_surface-to-jules-shared
* `jules_pftparm` migrated to **jules-shared**. * Hardwired values moved to upgrade macro. * Unused items for now ignored. * Plumbing in `jules_physics_init` incomplete and has an issue with the incorrect shape of the enumerated arrays - does not compile.
…-metadata-to-jules-shared (upgraded to include MetOffice#181)
* Upgrade macro added to replace hardwired values.
…jules_pftparm-metadata-to-jules-shared
* `jules_nvegarm` items with integer arrays added (no enumeration as not compatble with arrays).
…available to JULES interface. * `jules_pftparm` values printed out after copying to JULES module; configuration access changes tested.
…calars in LFRic apps.
…plicate namelist capability though this isn't to be extended to pftparm.
…tparm_mod in MetOffice/jules.
…jules_pftparm-metadata-to-jules-shared
…elist and allowed values added for pft_name_io.
iboutle
approved these changes
Apr 23, 2026
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
Contributor
|
James Bruten (@james-bruten-mo) this is ready for code review |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: iboutle
Code Reviewer: James Bruten (@james-bruten-mo)
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps-test-migrate-jules_pftparm-metadata-to-jules-shared/run1
Suite Information
Task Information
✅ succeeded tasks - 1171
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review