Configure LFRic to receive meltpond fields as grid box mean#431
Configure LFRic to receive meltpond fields as grid box mean#431Tim Graham (timgraham-Met) wants to merge 6 commits intoMetOffice:mainfrom
Conversation
|
KGOs for lfric_coupled have been updated and the check now passes. |
Mike Hobson (@mike-hobson) This change to the CONTRIBUTORS.md file is because the code change was originally developed by Alex West but I have made the final version of the branch and created the pull request. When I discussed with you, you suggested that Alex should be added as a contributor because he did the original development but that causes this check to fail. Can you comment on the best way forward? |
|
Hi Tim Graham (@timgraham-Met), I may have provided poor (or at least misleading) advice about the contributor's file. You are not allowed to add someone who is not yourself to that file. We can get around this, but in this case, GitHub doesn't know that Alex has contributed as it's your PR, so the easiest fix is just to not add Alex's name to the contributor's file. |
Remove Alex from contributors file to hopefully pass the CLA check
Thanks Mike Hobson (@mike-hobson). I've now removed Alex from the file and the CLA check is passing again. |
PR Summary
Sci/Tech Reviewer: Dan Copsey (@DanCopsey)
Code Reviewer: Alistair Pirrie (@mo-alistairp)
LFRic, and previously the UM, uses sea ice melt pond area fraction, and melt pond thickness, for surface albedo calculations (in JULES). Until now, these variables have been passed as mean over sea ice (melt pond area fraction) and as mean over melt pond area (melt pond thickness). Where there is covariance between these variables and sea ice area fraction within ocean cells underlying an LFRic grid cell, this can lead to surface albedo biases. Passing these variables as grid box means (GBM) is preferable, as it lets the atmosphere see a more representative sample of surface types.
A NEMO branch to allow melt pond variables to be sent as GBM has already been written; correspondingly, LFRic must be configured to receive them as such. After receipt, melt pond area fraction must be divided through by sea ice area fraction; melt pond thickness by sea ice area fraction and melt pond area fraction (or alternatively, by GBM melt pond area fraction in a single step). These changes have been applied to the NEMO package branch and the coupled rose stem test has been updated to the later revision of the branch.
Given that this change will be included in the first released coupled configuration using LFRic (GC6) it's suggested that the behaviour is included without a switch. There are no configurations that will need to use the old behaviour.
This code was originally developed by MO-AlexW but as it is a simple change that we have been using in GC workflows, I have picked it up to get on main.
Code Quality Checklist
Testing
This code has been used in multiple development versions of GC6.
trac.log
Test Suite Results - lfric_apps - mpnds_as_gbm/run1
Suite Information
Task Information
❌ failed tasks - 1
⌛ waiting tasks - 1
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review