Skip to content

Used getter and setter for io_value_type%data attribute#444

Open
allynt wants to merge 3 commits intoMetOffice:mainfrom
allynt:io_value_type
Open

Used getter and setter for io_value_type%data attribute#444
allynt wants to merge 3 commits intoMetOffice:mainfrom
allynt:io_value_type

Conversation

@allynt
Copy link
Copy Markdown
Contributor

@allynt allynt commented Apr 21, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Mike Hobson (@mike-hobson)

Now that the io_value_type%data attribute is private, access to it must be via getters and setter.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - io_value_type_apps/run33

Suite Information

Item Value
Suite Name io_value_type_apps/run33
Suite User allyn.treshansky
Workflow Start 2026-04-20T14:11:58
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@2026.03.2 True
lfric_apps allynt/lfric_apps@io_value_type False
lfric_core allynt/lfric_core@io_value_type True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@4387949 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@2026.03.2 True

Task Information

✅ succeeded tasks - 1165

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@allynt allynt requested review from a team and thomasmelvin as code owners April 21, 2026 07:33
@allynt allynt requested review from Ricky Wong (mo-rickywong) and removed request for a team April 21, 2026 07:33
@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Apr 21, 2026
@allynt allynt linked an issue Apr 21, 2026 that may be closed by this pull request
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new io_value_type getter & setter

2 participants