Release management: version string and components#446
Release management: version string and components#446mo-marqh wants to merge 2 commits intoMetOffice:mainfrom
Conversation
iboutle
left a comment
There was a problem hiding this comment.
I've certainly no issue with this, but I'm also not sure I should really be the code owner for this - I'm not sure if that means the file is in the wrong place - it doesn't feel like this is a science constant (certainly the science doesn't care about the revision number - in fact we explicitly mandate that the science is independent of the revision number). I'm not sure if there is somewhere else more suitable we should put it?
e6ed88e to
6c96d56
Compare
I think you're right iboutle, that this code is in the wrong place. I propose that we move the code to sit alongside |
That seems better - it still seems odd that it's in a top-level location called "science", but we don't really have anything like "control" or "infrastructure" in lfric_apps, which would seem like the more natural place for something like this to sit |
6c96d56 to
ef34c0c
Compare
Andrew Coughtrie (andrewcoughtrie)
left a comment
There was a problem hiding this comment.
A good change just the one question to answer and perhaps change but nothing major.
| integer(i_def), public, parameter :: lfric_apps_patch_version = 1 | ||
| logical(l_def), public, parameter :: lfric_apps_release_version = .false. | ||
| character(2), parameter :: prefix = 'vn' | ||
| character(4), parameter :: dev_suffix = '_dev' |
There was a problem hiding this comment.
is there any chance there is going to be a need to have incremental dev versions between releases? if so _dev0 might be better that way it is obviously incrementable when needed (is a pretty standard mechanism as well).
There was a problem hiding this comment.
I discussed this with James Bruten (@james-bruten-mo)
there is a follow up activity to document these behaviours in the working practices, that James is going to do as soon as this is approved.
At present there is no _dev working practice, so this is new, and we can agree to do what we think is best. I think the simpler option is to have a singular _dev suffix that is unchanging, and only indicates that this is not a release, it's somewhere in the code commit line between releases, or even on a branch.
I propose that we stick with this singular _dev suffix, and only adopt some sort of increment if we come up with a managed working practice to support it.
At present the only working practice is on releases, and that needs a bit more systems documentation to make facets explicit.
There was a problem hiding this comment.
Yep that's fine, I'm happy to leave it as is if this is the choice we are making 😸
PR Summary
Sci/Tech Reviewer: Andrew Coughtrie (@andrewcoughtrie)
Code Reviewer: James Bruten (@james-bruten-mo)
version numbering and string return function added to lfric_apps
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps_version/run4
Suite Information
Task Information
✅ succeeded tasks - 1185
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review