Output Metadata Validation Testing

[mo-marqh]

PR Summary

Sci/Tech Reviewer: Lottie Turner (@mo-lottieturner)
Code Reviewer: Cameron Bateman (@cameronbateman-mo)

Add testing infrastructure to run metadata validation tests as an opt-in follow on task to runs.

This includes two trivial metadata validation tests, to illustrate the framework we intend to build upon

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - validate_metadata_infrastructure/run5

Suite Information

Item	Value
Suite Name	validate_metadata_infrastructure/run5
Suite User	mark.hedley
Workflow Start	2026-04-29T09:19:26
Groups Run	lfric_atm_nwp_gal9-C12_azspice_gnu_fast-debug-32bit', 'lfric_atm_nwp_gal9_da-C12_azspice_gnu_fast-debug-32bit

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.03.2	True
jules	MetOffice/jules@2026.03.2	True
lfric_apps	mo-marqh/lfric_apps@validate_metadata_infrastructure	False
lfric_core	MetOffice/lfric_core@018e40c	True
moci	MetOffice/moci@2026.03.2	True
SimSys_Scripts	MetOffice/SimSys_Scripts@4387949	True
socrates	MetOffice/socrates@2026.03.2	True
socrates-spectral	MetOffice/socrates-spectral@2026.03.2	True
ukca	MetOffice/ukca@2026.03.2	True

Task Information

✅ succeeded tasks - 17

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Lottie Turner (mo-lottieturner)]

Looks good! A couple of test descriptions need correcting to match the tests.

Some musing: is it worth adding the flag to eg one test in gungho, one test in ngarch, etc? So they at least start with one test that checks their metadata.

[mo-marqh]

thanks Lottie Turner (@mo-lottieturner)

i've addressed to mistaken copied docstrings with relevant ones, and i've slightly changed the call with a view to future extensibility

i've rerun the few tests that trigger this task, to prove this code path is working

[Lottie Turner (mo-lottieturner)]

passing to Cameron Bateman (@cameronbateman-mo) for code review