Skip to content

Delete Jules metadata copy#463

Draft
James Bruten (james-bruten-mo) wants to merge 6 commits intoMetOffice:mainfrom
james-bruten-mo:delete_jules_meta
Draft

Delete Jules metadata copy#463
James Bruten (james-bruten-mo) wants to merge 6 commits intoMetOffice:mainfrom
james-bruten-mo:delete_jules_meta

Conversation

@james-bruten-mo
Copy link
Copy Markdown
Collaborator

@james-bruten-mo James Bruten (james-bruten-mo) commented Apr 29, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

This deletes lfric-jules-shared and jules-lfric metadata sections from lfric_apps now that the build system can extract the metadata from jules.
The metadata deleted is either already in, or has been copied to the Jules repo. Older versions are renamed to match Jules versions, with corresponding imports updated here.

  • linked MetOffice/jules#110

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - apps_delete_jules_meta/run2

Suite Information

Item Value
Suite Name apps_delete_jules_meta/run2
Suite User james.bruten
Workflow Start 2026-04-29T10:35:41
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules james-bruten-mo/jules@copy_lfric_meta True
lfric_apps james-bruten-mo/lfric_apps@delete_jules_meta False
lfric_core MetOffice/lfric_core@3c8ccc6 True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@cab3315 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@1cdb9c2 True

Task Information

✅ succeeded tasks - 1185

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants