Skip to content

Feat/connect bitcoin#195

Draft
NikosFotiadis wants to merge 6 commits intomainfrom
feat/connect-bitcoin
Draft

Feat/connect bitcoin#195
NikosFotiadis wants to merge 6 commits intomainfrom
feat/connect-bitcoin

Conversation

@NikosFotiadis
Copy link

Explanation

  • Adds the @metamask/connect-bitcoin package which wraps the @metamask/bitcoin-wallet-standard with MetaMask Connect.
  • Playground dapp support for bitcoin-wallet-standard

Testing Steps

  1. Install dependencies and build (yarn install && yarn build)
  2. Launch browser playground (yarn workspace @metamask/browser-playground start)
  3. Click Connect (Bitcoin) button (ensure no extension is installed if using desktop browser)
  4. Confirm connection -> Bitcoin Card should appear in dapp
  5. Try interactions available interactions like signMessage, which should succeed.

Important

Metamask does not support Bitcoin testnets so in oorder to test transactions you will need BTC on mainnet

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
    • Tests for @metamask/connect-bitcoin
    • Test for Bitcoin Card in the playground dapp
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​bitcoin-wallet-standard@​0.2.0751009490100
Addedbitcoinjs-lib@​7.0.19710010087100
Addedsats-connect@​4.2.1971009493100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant