Skip to content

Add global URN resolver #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uittenbroekrobbert merged 2 commits into from
Dec 19, 2024
Merged

Add global URN resolver #88

uittenbroekrobbert merged 2 commits into from
Dec 19, 2024

Conversation

@uittenbroekrobbert
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert commented Dec 18, 2024

Description

Add a global URN resolved under path /urns/{urn}

Resolves #403

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner December 18, 2024 15:04
@uittenbroekrobbert uittenbroekrobbert linked an issue Dec 18, 2024 that may be closed by this pull request
Implement an urn resolver in the task registry MinBZK/amt#403
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 403-implement-an-urn-resolver-in-the-task-registry branch 2 times, most recently from fa2e711 to cf13f9e Compare December 18, 2024 15:07
berrydenhartog
berrydenhartog approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ravimeijerrig
ravimeijerrig approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@uittenbroekrobbert uittenbroekrobbert force-pushed the 403-implement-an-urn-resolver-in-the-task-registry branch from cf13f9e to 079b4aa Compare December 19, 2024 08:22
@uittenbroekrobbert uittenbroekrobbert force-pushed the 403-implement-an-urn-resolver-in-the-task-registry branch from 079b4aa to f79ec8b Compare December 19, 2024 08:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@uittenbroekrobbert uittenbroekrobbert merged commit a1798a9 into main Dec 19, 2024
16 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 403-implement-an-urn-resolver-in-the-task-registry branch December 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurensWe laurensWe laurensWe approved these changes

@berrydenhartog berrydenhartog berrydenhartog approved these changes

@ravimeijerrig ravimeijerrig ravimeijerrig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement an urn resolver in the task registry

5 participants

@uittenbroekrobbert @laurensWe @berrydenhartog @ravimeijerrig