-
Notifications
You must be signed in to change notification settings - Fork 1
[wave-8] SafeArea added #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-3
Are you sure you want to change the base?
Conversation
| static const List<Locale> supportedLocales = <Locale>[ | ||
| Locale('en'), | ||
| Locale('ru'), | ||
| Locale('ru') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
старайся не коммитить ненужные изменения
| } | ||
|
|
||
| throw FlutterError( | ||
| 'AppLocalizations.delegate failed to load unsupported locale "$locale". This is likely ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
аналогично комменту выше - не стоит коммитить то, что не особо требуется обновлять (если некритичные изменения)
| type: WaveTextType.caption, | ||
| maxLines: 3, | ||
| textAlign: TextAlign.center, | ||
| return SafeArea( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
проверял? точно нужен тут safearea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я тут не особо понял, что вообще нужно, как будто можно обсудить этот момент
| this.purpleTitle, | ||
| required this.child, | ||
| required this.isAnimated, required this.topPadding, | ||
| required this.isAnimated, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Closes #13