Add visual PvP consent indicator#26
Conversation
- Implemented NameTagManager to handle scoreboard teams and prefixes. - Used Adventure API for modern component-based prefixes. - Added configuration options for the indicator. - Integrated indicators into join, quit, death, and toggle flows. Co-authored-by: benrobson <15405528+benrobson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. 👉 Get your free trial and get 200 agent minutes per Slack user (a $50 value). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔
|
- Implemented NameTagManager for visual PvP consent indicators using scoreboard teams. - Added 'force' option to indicators config to handle compatibility with other plugins. - Prevented players from being set on fire with flint & steel or fire charges if they have PvP disabled. - Ensured indicators and PvP state are correctly synchronized on join, quit, death, and reload. - Used Adventure API for modern component-based prefixes. - Cleaned up imports and improved plugin initialization sequence. Co-authored-by: benrobson <15405528+benrobson@users.noreply.github.com>
- Implemented NameTagManager for visual PvP consent indicators using scoreboard teams. - Added 'force' option to indicators config for compatibility with other plugins. - Prevented players from being set on fire with flint & steel or fire charges if PvP is disabled. - Added protection against TNT minecarts and other explosions for non-consenting players. - Ensured indicators and PvP state are correctly synchronized on join, quit, death, and reload. - Used Adventure API for modern component-based prefixes. - Cleaned up imports and improved plugin initialization sequence. Co-authored-by: benrobson <15405528+benrobson@users.noreply.github.com>
- Implemented NameTagManager for visual PvP consent indicators using scoreboard teams. - Added 'force' option to indicators config for compatibility with other plugins. - Prevented players from being set on fire with flint & steel or fire charges if they have PvP disabled. - Added protection against TNT minecarts and other explosions for non-consenting players. - Ensured indicators and PvP state are correctly synchronized on join, quit, death, and reload. - Used Adventure API for modern component-based prefixes. - Cleaned up imports and improved plugin initialization sequence. Co-authored-by: benrobson <15405528+benrobson@users.noreply.github.com>
Implemented a visual PvP consent indicator using scoreboard teams. Players will now have a prefix (green sword for enabled, red shield for disabled by default) above their heads indicating their current PvP state. The system is fully configurable and uses the modern Adventure/MiniMessage API.
PR created automatically by Jules for task 7392956729047764724 started by @benrobson