feat: Allow binding with user-provided credentials#55
Open
TuringTux wants to merge 61 commits intoMonogramm:masterfrom
Open
feat: Allow binding with user-provided credentials#55TuringTux wants to merge 61 commits intoMonogramm:masterfrom
TuringTux wants to merge 61 commits intoMonogramm:masterfrom
Conversation
Contributor
Author
|
@madmath03 Can I do something to help getting this merged? I think it would be nice to have these improvements in production; and they also improve the README a bit. I've been running the code in my setup since I've opened the PR, so I would say it is rather stable |
Contributor
Author
|
Everything after commit a1c0111 (i.e. everything added on or after today) should not be merged. I am currently working on getting my own fork ready for PyPI, hence the new commits. Of course, feel free to merge anything I change into your fork at any time. In principle, I'd prefer it if my fork didn't need to exist :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57: If you don't want to use an LDAP service user, you can now bind to the LDAP server with the user-specified credentials.
Changes
connector.pyto dedicated functions