Skip to content

Conversation

troyhacks
Copy link
Collaborator

@troyhacks troyhacks commented Apr 17, 2024

W5500/SPI Ethernet support, currently hardcoded for the T-Eth-Lite-S3 board - which is the only S3 board I know of with Ethernet:

https://www.lilygo.cc/en-ca/products/t-eth-lite

Needs lib_deps:

https://github.com/troyhacks/ETHClass2 (for W5500 support)
https://github.com/troyhacks/TroyHacksAsyncUDP (fixes a bug with AsyncUDP, backports some fixes from IDF v5.1)

Also likely needs IDF v4.4 to work correctly. Tested on v4.4.6.

Updated to use the new ETHClass2 - so there's a bunch of code ifdef'd out if it's an ESP32-S3 just to work around the fact that SPI Ethernet isn't really a thing we're accounting for at the moment in WLED - so I'd consider this a proof of concept, even if it works.

May be useful (not in this state) for adding SPI Ethernet to WLED for the original ESP32?

@troyhacks troyhacks added the enhancement New feature or request label Apr 17, 2024
@troyhacks troyhacks requested a review from softhack007 April 17, 2024 18:38
@troyhacks troyhacks marked this pull request as draft April 20, 2024 02:53
@januszwoj
Copy link

Hi @troyhacks .
If you need someone to test, I will be happy to help.
I am hopefully the lucky owner of Lilygo T-ETH-Lite-S3. I also have XIAO ESP32S3. In my case, they are supposed to work via I2S with WM8782S and PCM1808 ADC and DIR9001 SPDIF to I2S.
My programming skills are rather poor and I can't wait for support for T-ETH-Lite-S3 via ethernet, unfortunately my XIAO ESP32S3 somehow does not manage to stream the audio signal to the rest of the ESP32 via wifi.
Regards Janusz

@troyhacks
Copy link
Collaborator Author

Hi @troyhacks .
If you need someone to test, I will be happy to help.
I am hopefully the lucky owner of Lilygo T-ETH-Lite-S3. I also have XIAO ESP32S3. In my case, they are supposed to work via I2S with WM8782S and PCM1808 ADC and DIR9001 SPDIF to I2S.
My programming skills are rather poor and I can't wait for support for T-ETH-Lite-S3 via ethernet, unfortunately my XIAO ESP32S3 somehow does not manage to stream the audio signal to the rest of the ESP32 via wifi.
Regards Janusz

This is great, thanks @januszwoj !

Just to assess the level you can help here, do you know how to build WLED from the source code and upload the resulting firmware to the ESP32-S3?

@januszwoj
Copy link

Hi @troyhacks
I'm not very good at it yet, but I manage to do it from time to time.
Sometimes I have trouble understanding where some things come from, but I'm trying to learn.
I use Visual Studio and Platformio to compile the firmware myself.

@januszwoj
Copy link

Hi @troyhacks
I have been trying for several days to compile a program for esp32S3 with w5500 support from your Github: "W5500_Support."
After adding the switche: -D WLED_USE_ETHERNET; at first I received messages that it's missing <ETHClass2.h> library.
I've added the libraries: ETHClass2 & TroyHacksAsyncUDP from your Github to the lib_deps in platformio.
Thanks to this, the messages about the missing library disappeared. Unfortunately, a different message appeared now:

.pio/libdeps/esp32S3_8MB_S/ETHClass2/src/ETHClass2.cpp: In member function 'bool ETHClass2::beginSPI(eth_phy_type_t, uint8_t, int, int, int, int, int, int, spi_host_device_t, uint8_t)':

.pio/libdeps/esp32S3_8MB_S/ETHClass2/src/ETHClass2.cpp:403:15: error: 'digitalPinToGPIONumber' was not declared in this scope

 _pin_cs = digitalPinToGPIONumber(cs);

So far I haven't been able to figure out a way to jump over it.
Regards Januszz

Copy link

coderabbitai bot commented Feb 27, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@noman1228
Copy link

Are you still playing around with this? I have all the hardware and a good amount of coding experience but adding W5500 to OG ESP32 is what I'm interested in (8 RMT chans). Imagine the lower pin occupation could lead to wifi/eth/TFlash/OLED/butttons/MIC/ 8 channels one stop shop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request magic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants