forked from wled/WLED
-
-
Notifications
You must be signed in to change notification settings - Fork 111
Added code to handle Half-step encoders along with a config option #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kflin01
wants to merge
2
commits into
MoonModules:mdev
Choose a base branch
from
Kflin01:master
base: mdev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Incorrect half-step encoder logic implementation.
The half-step implementation has a fundamental logic error. Both the A-change and B-change branches use equivalent conditions, which would cause the same encoder state to trigger both clockwise and counter-clockwise actions.
Current logic:
(Enc_B == HIGH && Enc_A == LOW) || (Enc_B == LOW && Enc_A == HIGH)(Enc_A == HIGH && Enc_B == LOW) || (Enc_A == LOW && Enc_B == HIGH)These conditions are logically equivalent (just with A and B swapped), so they would both evaluate to true for the same encoder state.
The correct implementation should detect edge transitions and use the state of the other pin to determine direction:
if (HalfStep) { // WLEDMM: use half step for encoder - if (Enc_A != Enc_A_prev) { // WLEDMM: use rising edge detection - if ((Enc_B == HIGH && Enc_A == LOW) || (Enc_B == LOW && Enc_A == HIGH)) { + if (Enc_A != Enc_A_prev) { // A pin changed + if ((Enc_A == HIGH && Enc_B == LOW) || (Enc_A == LOW && Enc_B == HIGH)) { // Serial.println("A changed +"); // Clockwise switch(select_state) { case 0: changeBrightness(true); break; case 1: changeEffectSpeed(true); break; case 2: changeEffectIntensity(true); break; case 3: changePalette(true); break; case 4: changeEffect(true); break; case 5: changeHue(true); break; case 6: changeSat(true); break; case 7: changeCCT(true); break; case 8: changePreset(true); break; case 9: changeCustom(1,true); break; case 10: changeCustom(2,true); break; case 11: changeCustom(3,true); break; } + } else { + // Counter-clockwise + switch(select_state) { + case 0: changeBrightness(false); break; + case 1: changeEffectSpeed(false); break; + case 2: changeEffectIntensity(false); break; + case 3: changePalette(false); break; + case 4: changeEffect(false); break; + case 5: changeHue(false); break; + case 6: changeSat(false); break; + case 7: changeCCT(false); break; + case 8: changePreset(false); break; + case 9: changeCustom(1,false); break; + case 10: changeCustom(2,false); break; + case 11: changeCustom(3,false); break; + } } } - else { - if (Enc_B != Enc_B_prev) { - if ((Enc_A == HIGH && Enc_B == LOW) || (Enc_A == LOW && Enc_B == HIGH)) { + if (Enc_B != Enc_B_prev) { // B pin changed + if ((Enc_B == HIGH && Enc_A == HIGH) || (Enc_B == LOW && Enc_A == LOW)) { // Counter-clockwise // Serial.println("B changed -"); switch(select_state) { case 0: changeBrightness(false); break; case 1: changeEffectSpeed(false); break; case 2: changeEffectIntensity(false); break; case 3: changePalette(false); break; case 4: changeEffect(false); break; case 5: changeHue(false); break; case 6: changeSat(false); break; case 7: changeCCT(false); break; case 8: changePreset(false); break; case 9: changeCustom(1,false); break; case 10: changeCustom(2,false); break; case 11: changeCustom(3,false); break; } + } else { + // Clockwise + switch(select_state) { + case 0: changeBrightness(true); break; + case 1: changeEffectSpeed(true); break; + case 2: changeEffectIntensity(true); break; + case 3: changePalette(true); break; + case 4: changeEffect(true); break; + case 5: changeHue(true); break; + case 6: changeSat(true); break; + case 7: changeCCT(true); break; + case 8: changePreset(true); break; + case 9: changeCustom(1,true); break; + case 10: changeCustom(2,true); break; + case 11: changeCustom(3,true); break; + } } - } }🤖 Prompt for AI Agents