Fix Hub75 options showing in additional LED outputs without support #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hub75 LED type options were incorrectly appearing in dropdown menus for LED outputs 2+ even in firmware builds without Hub75 support compiled in.
Root Cause
The existing
hideHub75()
JavaScript function only executed once during initial page load. When users dynamically add new LED outputs by clicking the "+" button, the newly created select elements still contained all Hub75 options (values 101-108) because the function wasn't called again for the dynamically generated content.Solution
Modified the
addLEDs()
function insettings_leds.htm
to callhideHub75()
after each new LED output is created:The fix includes a safety check to prevent errors if the function doesn't exist and maintains full backward compatibility.
Testing
This minimal change ensures that builds without Hub75 support will never show Hub75 options in LED type dropdowns, regardless of how many LED outputs users configure.
Fixes #215.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
wled00
node tools/cdata.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.