Skip to content

Conversation

@Phylogeny
Copy link
Contributor

@Phylogeny Phylogeny commented Nov 24, 2018

It's not as nice, in my opinion; but it's worth adding as an option.

This PR also:

  1. Prevents the attempt to mute sounds when the percent is set to 1 (which in-turn prevents needlessly iterating through playingSounds).
  2. Centers (even while rotating) stun grenade entity models within their hitboxes, and moves them to the bottom to prevent them from hovering above the ground.

@MrCrayfish
Copy link
Owner

While going through the changes, I believe syncing the server config to client causes problems. It doesn't restore the clients config after leaving a server. A previously powerful weapon may become weak after joining and leaving a server.

@MrCrayfish
Copy link
Owner

I can go ahead and merge this. The solution to fix is to have a copy of the config then simply use getters instead of directly accessing the config values. Inside the getter I can check if the server config is not null, return the servers value otherwise just return client value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants