Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new SwiftUI compose component (LuminareButtonCompose) to lay out multiple buttons horizontally and apply default Luminare rounding behavior based on a positionInList hint, plus an environment value to control spacing.
Changes:
- Introduces
LuminareButtonComposewith a custom result builder and per-button rounding behavior. - Adds
luminareButtonComposeSpacingtoEnvironmentValuesfor configurable inter-button spacing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Sources/Luminare/Utilities/Extensions/EnvironmentValues+Extensions.swift | Adds an environment value for LuminareButtonCompose spacing. |
| Sources/Luminare/Components/Composes/LuminareButtonCompose.swift | Implements the new compose view, builder, list-position rounding logic, and a preview. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
e93c5f5 to
6bf80a2
Compare
|
I had to touch 2 unrelated files to pass lint, please tell me if i should revert that |
This pull request adds a component,
LuminareButtonCompose.It accepts Buttons, and also a
positionInListparameter that allows it to set default luminare button rounding to the buttons inside it.Example: