Skip to content

Add LuminareButtonCompose#29

Open
omeriadon wants to merge 23 commits intoMrKai77:mainfrom
omeriadon:luminare-button-compose
Open

Add LuminareButtonCompose#29
omeriadon wants to merge 23 commits intoMrKai77:mainfrom
omeriadon:luminare-button-compose

Conversation

@omeriadon
Copy link
Copy Markdown
Contributor

@omeriadon omeriadon commented Mar 23, 2026

This pull request adds a component, LuminareButtonCompose .

It accepts Buttons, and also a positionInList parameter that allows it to set default luminare button rounding to the buttons inside it.

Example:

LuminareButtonCompose(.bottom) {
    Button {
        print(1)
    } label: {
        Text("Button 1")
    }

    Button {
        print(1)
    } label: {
        Text("Button 1")
    }

    Button {
        print(2)
    } label: {
        Text("Button 2")
    }
}
SCR-20260323-naan

@omeriadon omeriadon marked this pull request as ready for review March 23, 2026 06:46
Copilot AI review requested due to automatic review settings March 23, 2026 06:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new SwiftUI compose component (LuminareButtonCompose) to lay out multiple buttons horizontally and apply default Luminare rounding behavior based on a positionInList hint, plus an environment value to control spacing.

Changes:

  • Introduces LuminareButtonCompose with a custom result builder and per-button rounding behavior.
  • Adds luminareButtonComposeSpacing to EnvironmentValues for configurable inter-button spacing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
Sources/Luminare/Utilities/Extensions/EnvironmentValues+Extensions.swift Adds an environment value for LuminareButtonCompose spacing.
Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Implements the new compose view, builder, list-position rounding logic, and a preview.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Utilities/Extensions/EnvironmentValues+Extensions.swift Outdated
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift
Comment thread Sources/Luminare/Utilities/Extensions/View+Extensions.swift
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Utilities/Extensions/View+Extensions.swift Outdated
Comment thread Sources/Luminare/Utilities/Extensions/EnvironmentValues+Extensions.swift Outdated
@omeriadon omeriadon marked this pull request as draft March 23, 2026 07:28
@omeriadon omeriadon requested a review from Copilot March 23, 2026 08:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Utilities/Extensions/View+Extensions.swift Outdated
Comment thread Sources/Luminare/Utilities/Extensions/Color+Extensions.swift
omeriadon and others added 3 commits March 23, 2026 17:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@omeriadon omeriadon force-pushed the luminare-button-compose branch from e93c5f5 to 6bf80a2 Compare March 23, 2026 09:14
@omeriadon omeriadon marked this pull request as ready for review March 23, 2026 09:18
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
Comment thread Sources/Luminare/Components/Composes/LuminareButtonCompose.swift Outdated
@omeriadon omeriadon marked this pull request as draft March 24, 2026 00:50
@omeriadon
Copy link
Copy Markdown
Contributor Author

I had to touch 2 unrelated files to pass lint, please tell me if i should revert that

@omeriadon omeriadon marked this pull request as ready for review March 26, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants