Method camera rendering, viewport preview, capability-gated GUI, shared eval#1407
Open
MrNeRF wants to merge 1 commit into
Open
Method camera rendering, viewport preview, capability-gated GUI, shared eval#1407MrNeRF wants to merge 1 commit into
MrNeRF wants to merge 1 commit into
Conversation
Methods advertising FramePreview render camera-dependent CUDA frames that publish through the existing tensor->Vulkan viewport path; the GUI hides 3dgs-only controls by capability and labels counts with the method's primitive noun. MetricsEvaluator renders via a callback so methods reuse the validation PSNR/SSIM protocol; the 3dgs path is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1406. Makes external training methods visible and comparable:
render_camera(request) -> {rgb, depth?, alpha?}onIMethodSession; frames publish through the existing CUDA-tensor -> Vulkan viewport upload (generation-based cache, latest-frame retention on resize; methods never touch Vulkan).renderVulkanFrameis inert unless an external session advertisesFramePreview; the 3dgs viewport path is unchanged (verified: 7k MCMC + eval smoke, PSNR 22.76/SSIM 0.598 on bicycle images_4).HostCheckpointIO.MetricsEvaluatorrenders via callback; methods withHostEvaluationget the same validation-camera PSNR/SSIM protocol (final evaluation after the session run).lichtfeld.trainer_method_info()exposes the active descriptor to Python plugins.Verified end-to-end with an out-of-tree module via
-DLFS_METHOD_PATHS: camera-dependent frames render live in the viewport and final eval produces a report.