Remove the interplanetary transfer maneuver#2233
Merged
Merged
Conversation
Retiring this button in favor of the adv transfer to another planet function. This was backed by the very old DeltaVAndTimeForInterplanetaryTransferEjection() algorithm in OrbitalManeuverCalculator, which is also just deleted. If it turns out people preferred going in through this menu item compared to using the porkchop plotter, we could bring the menu back and wire it up to the same InterplantearyTransfer maneuver solver in MJLib. The one feature which is lost here is the "WaitForPhaseAngle" button, which I'm guessing nobody understood what it did correctly. It was comparable to the "Match Orbit" button in the new Hohmann UI which does a 5-keplerian element match to the orbit rather than a 6-element rendezvous target. I think that makes more sense for Hohmann transfers where you might have satellites all in the same orbit. For planning orbits to e.g. L4/L5 leading/following a planet, I think a better way to do that would be to construct a target orbit manually (see #2232).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retiring this button in favor of the adv transfer to another planet function.
This was backed by the very old DeltaVAndTimeForInterplanetaryTransferEjection() algorithm in OrbitalManeuverCalculator, which is also just deleted.
If it turns out people preferred going in through this menu item compared to using the porkchop plotter, we could bring the menu back and wire it up to the same InterplantearyTransfer maneuver solver in MJLib.
The one feature which is lost here is the "WaitForPhaseAngle" button, which I'm guessing nobody understood what it did correctly. It was comparable to the "Match Orbit" button in the new Hohmann UI which does a 5-keplerian element match to the orbit rather than a 6-element rendezvous target. I think that makes more sense for Hohmann transfers where you might have satellites all in the same orbit.
For planning orbits to e.g. L4/L5 leading/following a planet, I think a better way to do that would be to construct a target orbit manually (see #2232).