Remove VesselState MovingAverage values#2240
Merged
Merged
Conversation
I suspect that these are MovingAverages either due to very old 2012-era KSP having more single precision floats than doubles and this was a workaround to precision jittering, or else it was just premature optimization. There's other places where the moving averages are deliberately being used to smooth out behavior. I might be wrong and that the low pass input filter is necessary for some control theory reasons, but I'd rather find that by breaking it and push that requirement for smoothing explicitly down into the consumers. I suspect that this might actually fix some bugs.
Collaborator
Author
|
I think they were introduced back in f85d41f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect that these are MovingAverages either due to very old 2012-era KSP having more single precision floats than doubles and this was a workaround to precision jittering, or else it was just premature optimization.
There's other places where the moving averages are deliberately being used to smooth out behavior.
I might be wrong and that the low pass input filter is necessary for some control theory reasons, but I'd rather find that by breaking it and push that requirement for smoothing explicitly down into the consumers.
I suspect that this might actually fix some bugs.