VesselState cleanup#2244
Merged
Merged
Conversation
There are absolutely breaking changes in here. This goes through and fixes most of the API surface and ensures it makes some kind of sense and is halfway consistent, and uses consistent code style, and will break quite a lot. Been putting this off for years, given the kos addon that someone else wrong which hits VesselState via reflection this needs to happen at least now. Should have happened years ago, but this is a large codebase.
Adds the ability to "version" the custom windows and force push updates to all users. This should eliminate users that don't get the Hoverslam Info window on update, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are absolutely breaking changes in here.
This goes through and fixes most of the API surface and ensures it makes
some kind of sense and is halfway consistent, and uses consistent code
style, and will break quite a lot.
Been putting this off for years, given the kos addon that someone else
wrong which hits VesselState via reflection this needs to happen at
least now. Should have happened years ago, but this is a large
codebase.