-
Notifications
You must be signed in to change notification settings - Fork 3
Sleuth #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sleuth #11
Conversation
…e running R scripts
…ler dataset has been generated
…le from kallisto_quant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code.
Please find my humble review comments.
docs/test_data/testData_Sleuth.rst
Outdated
.. code-block:: none | ||
:linenos: | ||
# Extract the original reads from teh FASTQ files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the* FASTQ
process_sleuth.py
Outdated
|
||
class process_sleuth(Workflow): | ||
""" | ||
Functions for processing Chip-Seq FastQ files. Files are the aligned, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then* aligned ?
process_sleuth.py
Outdated
metadata : dict | ||
Input file meta data associated with their roles | ||
kallisto_tar : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line duplicated ?
scripts/install_sleuth.R
Outdated
source("http://bioconductor.org/biocLite.R") | ||
if(!require("rhdf5")) biocLite("rhdf5") | ||
if(!require("devtools")) install.packages("devtools") | ||
if(!require("sleuth")) devtools::install_github("pachterlab/sleuth") No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new line sign
"file_path": "tests/data/kallisto.run_info.json", | ||
"file_path": "tests/data/kallisto.Human.ERR030872.tar.gz", | ||
"data_type": "data_rna_seq", | ||
"compressed": "null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Q) . What exactly is the compressed tag for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indicate if the file is compressed or not.
tidy_data.sh
Outdated
fi | ||
done | ||
|
||
# Added to remove the Sleuth results folder due to nexted structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neSted?
tool/kallisto_quant.py
Outdated
), | ||
"run_info_file": Metadata( | ||
"kallisto_tar_file": Metadata( | ||
data_type="data_ranseq", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rna* ?
} | ||
} | ||
] | ||
} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No newline error sign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as it is a JSON file
tool/sleuth.py
Outdated
|
||
class sleuthTool(Tool): # pylint: disable=invalid-name | ||
""" | ||
Tool for peak calling for iDamID-seq data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
( iDamID ? )
tool/sleuth.py
Outdated
def run(self, input_files, input_metadata, output_files): | ||
""" | ||
The main function to run Sleuth over a set of RNA-seq experiments | ||
nalysed using Kallisto to identify differentially expressed genes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analysed
…o that any dataset/expt info is also retained
…of the files metadata
Awaiting confirmation about the method for passing the parameters to the RNA-seq pipeline and Sleuth before merging. |
This is a new tools for the analysis of differential gene expression.
It has required changes to the original process_rnaseq pipeline for the packaging of the results as well as new pipelines and tools.