wasapi: detect device changes and handle disconnection gracefully#2538
Open
0x0003 wants to merge 2 commits into
Open
wasapi: detect device changes and handle disconnection gracefully#25380x0003 wants to merge 2 commits into
0x0003 wants to merge 2 commits into
Conversation
Catch exceptions from GetVolume()/SetVolume() so that a disconnected device (AUDCLNT_E_DEVICE_INVALIDATED) degrades gracefully instead of crashing MPD. Closes MusicPlayerDaemon#1880
Register an IMMNotificationClient to receive OnDefaultDeviceChanged callbacks. On change, the output thread wakes and reopens on the new default device immediately, bypassing the 10-second fail timer via a new AudioOutput::IsDeviceChange() virtual. Closes MusicPlayerDaemon#1408 Closes MusicPlayerDaemon#1880
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1408
Closes #1880
Changes were made to Control.hxx, Interface.hxx, Thread.cxx, which are technically a bit out of scope as those are generic, but I couldn't figure out how to make it work some other way.
Their behavior essentially stays the same though, so no other platforms should be affected.