Dev task page#11
Conversation
WalkthroughThis update introduces numerous enhancements across the project. It adjusts the analyzer settings, adds a success animation asset, and provides new Flutter UI components for task and project management such as Kanban boards and section addition. Additionally, the changes add remote data sources, repositories, domain entities, and BLoC components for project and task operations. Dependency injection is updated to register new services, and automated workflows are implemented in PocketBase to create boards and categories upon project creation. New dependencies are also added to support drag‐and‐drop functionality and Font Awesome icons. Changes
Sequence Diagram(s)sequenceDiagram
participant PB as PocketBase Handler
participant Project as Project Record
participant Board as Board Record
participant Cat as createCategories Function
Project->>PB: OnRecordAfterCreateSuccess (Project Created)
PB->>PB: Initiate board creation
PB->>Board: Save new board record linked to Project
Board-->>PB: Board creation successful
PB->>Cat: Call createCategories(boardID)
Cat-->>PB: Return created category IDs
PB->>Project: Update project with board reference
PB->>PB: Log board creation success
sequenceDiagram
participant UI as HomePage UI
participant Bloc as ProjectBloc
UI->>Bloc: Request current project state
Bloc-->>UI: Return state (currentProject null or present)
alt No current project
UI->>UI: Render TopBar & MainDashboard
else Project exists
UI->>UI: Render TaskPage
end
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 17
🧹 Nitpick comments (60)
lib/features/home/domain/entities/status.dart (1)
1-15: Consider enhancing the Status entity with documentation and Equatable implementation.The Status class provides a solid foundation with immutable properties and required parameters. To improve clarity and functionality, consider:
- Adding class-level documentation to explain this entity's purpose
- Implementing Equatable for easy comparison of Status instances
- Adding toString() for debugging purposes
+import 'package:equatable/equatable.dart'; + +/// Represents a status that can be assigned to tasks. +/// e.g., "To Do", "In Progress", "Done" -class Status { +class Status extends Equatable { final String id; final String name; final String createdBy; final DateTime created; final DateTime updated; Status({ required this.id, required this.name, required this.createdBy, required this.created, required this.updated, }); + + @override + List<Object> get props => [id, name, createdBy, created, updated]; + + @override + String toString() => 'Status(id: $id, name: $name)'; }lib/features/home/domain/entities/board.dart (1)
1-15: Consider enhancing the Board entity with documentation and Equatable implementation.The Board class has a good structure with immutable properties, but would benefit from:
- Adding class-level documentation to explain its purpose and relationship with Project
- Implementing Equatable for equality comparison
- Strong typing for categories (if applicable)
- Adding toString() method for debugging
+import 'package:equatable/equatable.dart'; + +/// Represents a board within a project that contains multiple categories +/// for organizing tasks (e.g., Kanban board). -class Board { +class Board extends Equatable { final String id; final String project; final List<String> categories; final DateTime created; final DateTime updated; Board({ required this.id, required this.project, required this.categories, required this.created, required this.updated, }); + + @override + List<Object> get props => [id, project, categories, created, updated]; + + @override + String toString() => 'Board(id: $id, project: $project, categories: ${categories.length})'; }lib/features/home/domain/entities/project.dart (1)
4-22: Consider enhancing the Project entity with documentation and Equatable implementation.The Project class is well-structured but would benefit from:
- Adding class-level documentation
- Implementing Equatable for equality comparison
- Adding toString() for debugging
- Clarifying the unused imports (User is imported but not directly used)
+import 'package:equatable/equatable.dart'; + +/// Represents a project which contains tasks organized on a board. +/// A project has an owner and various metadata attributes. -class Project { +class Project extends Equatable { final String id; final String name; final String description; final String owner; final String board; final DateTime created; final DateTime updated; Project({ required this.id, required this.name, required this.description, required this.owner, required this.board, required this.created, required this.updated, }); + + @override + List<Object> get props => [id, name, description, owner, board, created, updated]; + + @override + String toString() => 'Project(id: $id, name: $name)'; }lib/features/auth/view/bloc/auth_bloc.dart (2)
136-136: Consider using proper logging instead of print statementsWhile print statements are useful for debugging, they should be replaced with a proper logging system before production deployment. Consider using a logging package like
loggerorlogging.- print('Checking session'); + // Use proper logging instead + logger.d('Checking session');
150-150: Use string interpolation instead of concatenationDart best practices recommend using string interpolation rather than concatenation for better readability and performance.
- print('Checking auth store ' + record.toString()); + print('Checking auth store ${record.toString()}');lib/features/home/domain/entities/task.dart (1)
2-22: Consider extending Equatable for easier comparisonsThe Task entity could benefit from extending Equatable to simplify equality comparisons and implement proper hashCode values. Also, consider adding utility methods like copyWith for easier state manipulation.
+import 'package:equatable/equatable.dart'; -class Task { +class Task extends Equatable { final String id; final String title; final String description; final DateTime dueTime; final String status; final List<String> assignedTo; final DateTime created; final DateTime updated; Task({ required this.id, required this.title, required this.description, required this.dueTime, required this.status, required this.assignedTo, required this.created, required this.updated, }); + + @override + List<Object?> get props => [id, title, description, dueTime, status, assignedTo, created, updated]; + + Task copyWith({ + String? id, + String? title, + String? description, + DateTime? dueTime, + String? status, + List<String>? assignedTo, + DateTime? created, + DateTime? updated, + }) { + return Task( + id: id ?? this.id, + title: title ?? this.title, + description: description ?? this.description, + dueTime: dueTime ?? this.dueTime, + status: status ?? this.status, + assignedTo: assignedTo ?? this.assignedTo, + created: created ?? this.created, + updated: updated ?? this.updated, + ); + } }lib/features/home/domain/entities/category.dart (2)
1-17: Consider extending Equatable and adding utility methodsSimilar to the Task entity, the Category class would benefit from extending Equatable and including utility methods like copyWith.
+import 'package:equatable/equatable.dart'; -class Category { +class Category extends Equatable { final String id; final String name; final int position; final List<String> tasks; final DateTime created; final DateTime updated; Category({ required this.id, required this.name, required this.position, required this.tasks, required this.created, required this.updated, }); + + @override + List<Object?> get props => [id, name, position, tasks, created, updated]; + + Category copyWith({ + String? id, + String? name, + int? position, + List<String>? tasks, + DateTime? created, + DateTime? updated, + }) { + return Category( + id: id ?? this.id, + name: name ?? this.name, + position: position ?? this.position, + tasks: tasks ?? this.tasks, + created: created ?? this.created, + updated: updated ?? this.updated, + ); + } }
5-5: Clarify the relationship between tasks and categoriesThe tasks field is a List, suggesting it stores task IDs. Consider adding a clear comment or changing to a more descriptive name like taskIds to make this relationship more explicit.
final String id; final String name; final int position; - final List<String> tasks; + final List<String> taskIds; // IDs of tasks that belong to this category final DateTime created; final DateTime updated;lib/features/home/view/widget/vertical-divider.dart (1)
3-27: Add documentation and use theme colorsThis widget could benefit from documentation and should use theme colors instead of hardcoded values.
import 'package:flutter/material.dart'; +/// A custom vertical divider widget that can be easily reused throughout the app. +/// +/// This widget wraps Flutter's [VerticalDivider] in a [SizedBox] with configurable +/// height, width, thickness, and color properties. class VerticalDividerWidget extends StatelessWidget { final double height; final double width; final double thickness; final Color color; const VerticalDividerWidget({ super.key, this.height = 40, this.width = 25, this.thickness = 2, - this.color = Colors.teal, + this.color = Colors.grey, }); @override Widget build(BuildContext context) { + // Use theme color if available + final themeColor = Theme.of(context).dividerColor; return SizedBox( height: height, child: VerticalDivider( width: width, thickness: thickness, - color: color, + color: color == Colors.grey ? themeColor : color, ), ); } }lib/features/home/data/models/project_model.dart (1)
25-35: Consider adding copyWith method for easy model updates.For better maintainability, consider adding a copyWith method to allow creating updated instances of the model without having to specify all parameters.
+ ProjectModel copyWith({ + String? id, + String? name, + String? description, + String? owner, + String? board, + DateTime? created, + DateTime? updated, + }) { + return ProjectModel( + id: id ?? this.id, + name: name ?? this.name, + description: description ?? this.description, + owner: owner ?? this.owner, + board: board ?? this.board, + created: created ?? this.created, + updated: updated ?? this.updated, + ); + }lib/features/home/Tsak/task-card.dart (4)
1-4: Fix directory naming: "Tsak" should be "Task"The directory name "Tsak" appears to be misspelled. This could lead to confusion and makes the codebase less intuitive to navigate. Consider renaming the directory to "Task" to maintain consistency.
5-9: Use const constructor for better performanceSince TaskCard is a StatelessWidget with immutable properties, you should mark the constructor as const to improve performance through widget reuse.
- TaskCard({required this.task, required this.onAssign}); + const TaskCard({required this.task, required this.onAssign});
13-26: Use theme colors instead of hardcoded valuesThe CircleAvatar is using a hardcoded color (
Colors.grey[300]). For better theme consistency, consider using theme colors from the context.return Card( elevation: 3, child: ListTile( title: Text(task.title), trailing: IconButton( icon: CircleAvatar( radius: 12, - backgroundColor: Colors.grey[300], + backgroundColor: Theme.of(context).colorScheme.surface, child: Icon(Icons.person, size: 16), ), onPressed: onAssign, ), ), );
11-27: Consider adding more task information to the cardThe current implementation only displays the task title. Consider enhancing the card to show more information like due date, status, or a preview of the description to make it more useful.
lib/features/home/data/models/task_model.dart (3)
21-21: Consider using an enum for task statusUsing a string for status could lead to inconsistencies. Consider defining an enum for possible task statuses and converting between string and enum in the serialization methods.
enum TaskStatus { todo, inProgress, done, // Add other statuses as needed } // Then in fromJson: status: _stringToTaskStatus(json['status'] as String), // Add a helper method: TaskStatus _stringToTaskStatus(String status) { switch (status.toLowerCase()) { case 'todo': return TaskStatus.todo; case 'in_progress': return TaskStatus.inProgress; case 'done': return TaskStatus.done; default: return TaskStatus.todo; } } // And in toJson: 'status': _taskStatusToString(status), // With helper method: String _taskStatusToString(TaskStatus status) { switch (status) { case TaskStatus.todo: return 'todo'; case TaskStatus.inProgress: return 'in_progress'; case TaskStatus.done: return 'done'; default: return 'todo'; } }
3-13: Add documentation comments to the class and methodsAdding documentation comments would improve code readability and help other developers understand the purpose and usage of this class.
+/// A model class that represents a Task entity with JSON serialization support. +/// This model extends the Task entity and provides methods to convert between +/// JSON and Task objects. class TaskModel extends Task { + /// Creates a new TaskModel with required fields. TaskModel({ required super.id, required super.title, required super.description, required super.dueTime, required super.status, required super.assignedTo, required super.created, required super.updated, });
15-26: Validate input data before creating modelConsider adding validation for the input data to ensure it meets the expected format and requirements before creating the model instance.
factory TaskModel.fromJson(Map<String, dynamic> json) { + // Validate required fields + if (json['id'] == null || json['title'] == null) { + throw FormatException('Missing required fields in JSON'); + } + return TaskModel( id: json['id'] as String, title: json['title'] as String, - description: json['description'] as String, + description: json['description'] as String? ?? '', dueTime: DateTime.parse(json['due_time']), status: json['status'] as String, assignedTo: List<String>.from(json['assigned_to'] ?? []), created: DateTime.parse(json['created']), updated: DateTime.parse(json['updated']), ); }analysis_options.yaml (1)
11-12: Consider adding mounted checks instead of disablinguse_build_context_synchronouslyRather than disabling the
use_build_context_synchronouslyrule, consider adding checks to ensure widgets are still mounted after async operations:// Example of proper pattern: void _loadDataAndUpdateUI() async { final data = await fetchData(); if (!mounted) return; // Add this check after async operations // Now it's safe to use context Navigator.of(context).pop(); }lib/features/home/view/widget/top_bar.dart (5)
42-48: Fix inconsistent formatting and spacingThere's inconsistent formatting in the code:
- Line 47 has no space between the closing parenthesis and the SizedBox declaration
- Some dividers have a SizedBox after them while others don't
VerticalDividerWidget(), HoverIconButton( tooltip: 'Timer', onPressed: () {}, child: Icon(Icons.timer, color: AppDesign.primaryText, size: 30), - ), SizedBox(width: 20), + ), + SizedBox(width: 20),
66-67: Add consistent spacing after vertical dividerFor consistency, add a SizedBox after this VerticalDividerWidget similar to how it's done elsewhere.
VerticalDividerWidget(), + SizedBox(width: 20), HoverIconButton(
72-76: Add error handling for network image loadingThe profile avatar loads directly from a network URL without any error handling. Consider adding a placeholder or error handling for when the image fails to load.
child: CircleAvatar( - backgroundImage: NetworkImage( - '${Config.pocketBaseUrl}/api/files/${user.collectionId}/${user.id}/${user.avatar}'), + backgroundImage: NetworkImage( + '${Config.pocketBaseUrl}/api/files/${user.collectionId}/${user.id}/${user.avatar}'), + onBackgroundImageError: (exception, stackTrace) { + // Log error and fallback to placeholder + }, + child: user.avatar.isEmpty ? Icon(Icons.person) : null, radius: 18, ),
9-11: Consider translating comments to EnglishThe comments in Arabic may limit code maintainability for international teams. Consider translating them to English to ensure all developers can easily understand the codebase.
- // ============================================= - // Top Bar Widget مع تأثير hover للأيقونات - // ============================================= + // ============================================= + // Top Bar Widget with hover effect for icons + // =============================================
19-23: Use theme dimensions instead of hardcoded valuesThe widget uses hardcoded values for height and padding. Consider using theme-based dimensions for better responsiveness and consistency.
return Container( - height: 70, // ارتفاع الشريط العلوي + height: Theme.of(context).appBarTheme.toolbarHeight ?? 70, color: Colors.transparent, // الشريط شفاف تماماً - padding: EdgeInsets.symmetric(horizontal: 16), + padding: EdgeInsets.symmetric(horizontal: Theme.of(context).padding.horizontal), child: Row(lib/features/home/Tsak/top-bar-task.dart (4)
7-10: Add class documentation.Consider adding documentation comments to explain the purpose and usage of the
TopBarTaskwidget.
76-81: Add error handling for avatar image loading.The NetworkImage doesn't handle potential loading failures. Consider adding error handling to display a fallback image or placeholder when the avatar fails to load.
- backgroundImage: NetworkImage( - '${Config.pocketBaseUrl}/api/files/${user.collectionId}/${user.id}/${user.avatar}'), + backgroundImage: NetworkImage( + '${Config.pocketBaseUrl}/api/files/${user.collectionId}/${user.id}/${user.avatar}'), + onBackgroundImageError: (exception, stackTrace) { + debugPrint('Error loading avatar: $exception'); + }, + child: user.avatar.isEmpty ? Text(user.name[0]) : null,
12-86: Extract hardcoded values to constants or theme.There are several hardcoded values like colors, sizes, and padding that should be extracted to constants or theme values for better maintainability.
For example:
+ // Constants for the top bar + const double _topBarHeight = 70.0; + const double _iconSize = 30.0; + const double _spacing = 20.0; + const double _avatarRadius = 18.0; + const Color _iconColor = Colors.black87; + const Color _menuIconColor = Color.fromARGB(221, 48, 48, 48); @override Widget build(BuildContext context) { return Container( - height: 70, + height: _topBarHeight, color: Colors.white, - padding: EdgeInsets.symmetric(horizontal: 16), + padding: const EdgeInsets.symmetric(horizontal: 16), // ... ); }
64-68: Consider pluralizing tooltip text.Change "My Task" to "My Tasks" for better grammar (assuming this button shows multiple tasks).
- tooltip: 'My Task', + tooltip: 'My Tasks',lib/features/home/view/bloc/project_event.dart (2)
12-15: Overridepropsgetter to include theidproperty.The
RequestProjectEventclass has anidproperty but doesn't override thepropsgetter to include it. Without this, equality comparisons fromEquatablewon't consider theidproperty.class RequestProjectEvent extends ProjectEvent { final String id; const RequestProjectEvent({required this.id}); + + @override + List<Object> get props => [id]; }
17-20: Overridepropsgetter to include theidproperty.The
ChangeCurrentProjectEventclass has anidproperty but doesn't override thepropsgetter to include it. Without this, equality comparisons fromEquatablewon't consider theidproperty.class ChangeCurrentProjectEvent extends ProjectEvent { final String id; const ChangeCurrentProjectEvent({required this.id}); + + @override + List<Object> get props => [id]; }pocketbase/main.go (3)
79-79: Fix typo in category name."In Pogress" should be "In Progress".
- titles := []string{"To Do", "In Pogress", "Done"} + titles := []string{"To Do", "In Progress", "Done"}
21-67: Consider extracting board creation into a separate function.The board creation logic is quite lengthy. Consider extracting it into a dedicated function for better readability and maintainability.
app.OnRecordAfterCreateSuccess("projects").BindFunc(func(e *core.RecordEvent) error { + return createBoardForProject(e, app) +}) +func createBoardForProject(e *core.RecordEvent, app *pocketbase.PocketBase) error { collection, err := app.FindCollectionByNameOrId("boards") if err != nil { return err } log.Println("creating board for project", e.Record.Id) // ... rest of the board creation logic ... log.Println("created board for project", e.Record.Id) return e.Next() }
43-49: Improve conditional logic for setting categories.This conditional block can be simplified since the error check has already been performed above.
- if(ids!=nil){ + // If we get here, ids is guaranteed to be non-nil since we've already checked for errors boardRecord.Set("categories",ids) err = app.Save(boardRecord) if err != nil { return err } - }lib/features/home/Tsak/add-section.dart (4)
38-43: Consider using theme colors instead of hardcoded values.The Container uses hardcoded color values. Consider using theme colors for better maintainability and consistent styling across the app.
decoration: BoxDecoration( - color: Colors.white, + color: Theme.of(context).cardColor, ),
47-76: Use theme colors for consistent styling.The header container uses a hardcoded green color. Consider using theme colors for better maintainability and app-wide consistency.
decoration: BoxDecoration( - color: Colors.green, + color: Theme.of(context).primaryColor, ),
63-73: Consider extracting the delayed focus logic.The delayed focus logic could be extracted into a separate method for better readability and reusability.
onTap: () { setState(() { isAdding = true; - Future.delayed(Duration(milliseconds: 100), () { - FocusScope.of(context).requestFocus(columnFocusNode); - }); + _setFocusAfterDelay(); }); }, child: Icon(Icons.add, size: 28, color: Colors.white), ), + void _setFocusAfterDelay() { + Future.delayed(Duration(milliseconds: 100), () { + if (mounted) { + FocusScope.of(context).requestFocus(columnFocusNode); + } + }); + }
102-125: Implement the Invite button or add a TODO comment.The "Invite" button has an empty onPressed callback. Either implement the functionality or add a TODO comment to indicate that it's a future feature.
ElevatedButton( - onPressed: () {}, + onPressed: () { + // TODO: Implement member invitation functionality + }, child: Text("Invite"), ),lib/features/home/domain/repository/project_repo.dart (1)
10-13: Add type annotation to callback parameter.The
onProjectsUpdatesmethod is missing a type annotation for thecallBackparameter, which could lead to type safety issues.- Future<void> onProjectsUpdates(callBack); + Future<void> onProjectsUpdates(Function callBack);For even better type safety, consider specifying the exact function signature:
- Future<void> onProjectsUpdates(Function callBack); + Future<void> onProjectsUpdates(void Function(List<Project>?) callBack);lib/features/home/view/pages/home_page.dart (1)
108-119: Simplify redundant gradient colors.The gradient is using four identical colors, which is unnecessary. Consider simplifying to a solid color or using different colors for an actual gradient effect.
gradient: LinearGradient( colors: [ - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), + Color.fromARGB(255, 27, 46, 55) ], - stops: [0.0, 0.33, 0.66, 1.0], begin: Alignment.topLeft, end: Alignment.bottomRight, ),Or simply:
- decoration: BoxDecoration( - gradient: LinearGradient( - colors: [ - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), - Color.fromARGB(255, 27, 46, 55), - ], - stops: [0.0, 0.33, 0.66, 1.0], - begin: Alignment.topLeft, - end: Alignment.bottomRight, - ), - ), + decoration: BoxDecoration( + color: Color.fromARGB(255, 27, 46, 55), + ),lib/injection_container.dart (2)
65-78: Fix typo in function name and remove unnecessary async.The function name "initPojects" appears to be a typo and should be "initProjects". Also, the function is marked as async but doesn't use await.
-void initPojects() async { +void initProjects() {
80-80: Remove unnecessary async modifier.The
initAuthfunction is marked as async but doesn't use await anywhere in its implementation.-void initAuth() async { +void initAuth() {lib/features/home/domain/repository/tasks_repo.dart (1)
3-9: Well-designed repository interface.The TaskRepository interface provides a clean, well-defined contract for task operations. All necessary CRUD operations are covered with appropriate method signatures and return types.
Consider adding additional functionality that might be useful:
- Methods for filtering tasks by properties (status, assignee)
- Batch operations (create/update multiple tasks)
- A method to get tasks for a specific project
lib/features/home/view/bloc/project_bloc.dart (2)
15-15: Fix method name spelling.There's a typo in the method name "registerProjcetsUpdate" - it should be "registerProjectsUpdate".
- registerProjcetsUpdate(); + registerProjectsUpdate();
16-16: Remove unnecessary empty event handler.The empty handler for ProjectEvent doesn't serve any purpose and can be removed.
- on<ProjectEvent>((event, emit) {});lib/features/home/view/bloc/project_state.dart (1)
34-37: Fix class name spelling.There's a typo in the class name "FaildToLoadProject" - it should be "FailedToLoadProject" for consistency.
-final class FaildToLoadProject extends ProjectState { - const FaildToLoadProject( +final class FailedToLoadProject extends ProjectState { + const FailedToLoadProject( {required super.projects, required super.currentProject}); }lib/features/home/data/repository/task_repo_impl.dart (2)
21-30: Extract task-to-map conversion to avoid duplication.The code for converting a Task object to a map is duplicated in both createTask and updateTask methods.
Create a helper method to avoid duplication:
+ Map<String, dynamic> _taskToMap(Task task) { + return { + "title": task.title, + "description": task.description, + "due_time": task.dueTime.toIso8601String(), + "status": task.status, + "assigned_to": task.assignedTo, + }; + } + @override Future<Task> createTask(Task task) async { - final data = { - "title": task.title, - "description": task.description, - "due_time": task.dueTime.toIso8601String(), - "status": task.status, - "assigned_to": task.assignedTo, - }; + final data = _taskToMap(task); return await remoteDataSource.createTask(data); }
32-42: Use the helper method for updateTask as well.Apply the same helper method to updateTask for consistency.
@override Future<Task> updateTask(Task task) async { - final data = { - "title": task.title, - "description": task.description, - "due_time": task.dueTime.toIso8601String(), - "status": task.status, - "assigned_to": task.assignedTo, - }; + final data = _taskToMap(task); return await remoteDataSource.updateTask(task.id, data); }lib/features/home/Tsak/kanban.dart (3)
1-7: Check the folder name spelling "Tsak"The folder name appears to be misspelled as "Tsak" instead of "Task" in the import paths. This typo might cause confusion and should be corrected to maintain code clarity and consistency.
308-332: Improve mouse cursor hover behaviorThe implementation uses MouseRegion to detect hover state for the drag area, but the visual feedback (showing a hand icon) might be confusing as it only appears when hovering. Consider showing a subtle hint always visible or improving the hover state transition.
- child: _isDragAreaHovered - ? Icon(FontAwesomeIcons.handPaper, - size: 25, color: Colors.white) - : SizedBox.shrink(), + child: Icon( + FontAwesomeIcons.handPaper, + size: 25, + color: _isDragAreaHovered ? Colors.white : Colors.white.withOpacity(0.5), + ),
368-371: Enhance drag and drop validationThe
onWillAcceptmethod always returns true, which means any draggable item can be dropped here. Consider adding validation logic to ensure only compatible items can be dropped.- onWillAccept: (data) => true, + onWillAccept: (data) => data != null,lib/features/home/data/data_sources/task_remote_source.dart (1)
13-46: Consider adding real-time update functionalityThe ProjectRemoteDataSource has methods for real-time updates (onProjectUpdate, onProjectsUpdates) but TaskRemoteDataSource doesn't. For consistency, consider adding similar functionality for tasks.
Add these methods to the TaskRemoteDataSource interface:
Future<void> onTaskUpdate(String id, Function(TaskModel) callback); Future<void> onTasksUpdates(Function callback);And implement them in TaskRemoteDataSourceImpl:
@override Future<void> onTaskUpdate(String taskId, Function(TaskModel) callback) async { await pocketBase.collection('tasks').subscribe( taskId, (e) { callback(TaskModel.fromJson(e.record!.toJson())); }, ); } @override Future<void> onTasksUpdates(Function callback) async { await pocketBase.collection('tasks').subscribe("*", (e) { callback(); }); }lib/features/home/data/repository/project_repo_impl.dart (3)
20-29: Fix parameter name typo and remove debug printThere's a typo in the parameter name "desdescription" and a debug print statement that should be removed in production code.
@override Future<Project> createProject( - String name, String desdescription, String owner) async { + String name, String description, String owner) async { final data = { "name": name, - "description": desdescription, + "description": description, "owner": owner, }; - print(data); return await remoteDataSource.createProject(data); }
53-56: Fix missing type annotation for callbackThe onProjectsUpdates method is missing the type annotation for the callback parameter.
@override - Future<void> onProjectsUpdates(callBack) async { + Future<void> onProjectsUpdates(Function callBack) async { return await remoteDataSource.onProjectsUpdates(callBack); }
10-13: Be consistent with async return statementsSome methods use
return awaitwhile others just usereturn. For consistency, choose one approach for all methods.@override Future<List<Project>?> getProjects() async { - return remoteDataSource.fetchProjects(); + return await remoteDataSource.fetchProjects(); }Also applies to: 15-18, 43-46, 48-51
lib/features/home/data/data_sources/project_remote_source.dart (2)
63-71: Add type annotations to callback parametersThe callback function lacks type annotations, making it unclear what type of data is expected. Add proper type annotations to improve code clarity.
@override - Future<void> onProjectUpdate(String projectId, Function callBack) async { + Future<void> onProjectUpdate(String projectId, Function(ProjectModel) callBack) async { // Subscribe to changes only in the specified record await pocketBase.collection('projects').subscribe( projectId, (e) { callBack(ProjectModel.fromJson(e.record!.toJson())); }, ); }
73-79: Remove debug print and improve callback parameterThe debug print statement should be removed in production code, and the callback should provide the updated data for better usability.
@override - Future<void> onProjectsUpdates(Function callBack) async { + Future<void> onProjectsUpdates(Function() callBack) async { - print("Register Updates For projects"); await pocketBase.collection('projects').subscribe("*", (e) { callBack(); }); }lib/features/home/Tsak/task-page.dart (2)
44-70: Consider making initial columns more dynamic
Hardcoding the default columns is a good start, but loading them from a remote config or database in the future could make the application more flexible as requirements evolve.
71-77: Consider providing feedback after adding a task
It might be helpful to reset the input or display a quick message (e.g., aSnackBar) indicating that the new task was successfully added.lib/features/home/view/widget/sliding_menu.dart (3)
29-36: Consider usingBlocBuilderfor project list
While manually storingprojectsin a local state is valid, relying on aBlocBuilderto rebuild on state changes can reduce boilerplate and streamline your reactive patterns.
105-129: Handle loading and error states in_buildProjectsContent
UsingBlocListenerto set your localprojectsis fine, but consider showing a loading indicator or error message if fetching fails, improving UX and clarity.
225-319: Add error handling for project creation
Currently, the dialog dismisses immediately after callingcreateProject. Consider showing error messages or success feedback if the creation process encounters any issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
pocketbase/pb_data/auxiliary.dbis excluded by!**/*.dbpocketbase/pb_data/data.dbis excluded by!**/*.dbpocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/avatar_c4s5cv0i28.jpgis excluded by!**/*.jpgpocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/avatar_i2vogq923e.jpgis excluded by!**/*.jpgpocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/thumbs_avatar_i2vogq923e.jpg/100x100_avatar_i2vogq923e.jpgis excluded by!**/*.jpgpocketbase/task_app.exeis excluded by!**/*.exepubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (35)
analysis_options.yaml(1 hunks)assets/success_animation.json(1 hunks)lib/features/auth/view/bloc/auth_bloc.dart(3 hunks)lib/features/home/Tsak/add-section.dart(1 hunks)lib/features/home/Tsak/kanban.dart(1 hunks)lib/features/home/Tsak/task-card.dart(1 hunks)lib/features/home/Tsak/task-page.dart(1 hunks)lib/features/home/Tsak/top-bar-task.dart(1 hunks)lib/features/home/data/data_sources/project_remote_source.dart(1 hunks)lib/features/home/data/data_sources/task_remote_source.dart(1 hunks)lib/features/home/data/models/project_model.dart(1 hunks)lib/features/home/data/models/task_model.dart(1 hunks)lib/features/home/data/repository/project_repo_impl.dart(1 hunks)lib/features/home/data/repository/task_repo_impl.dart(1 hunks)lib/features/home/domain/entities/board.dart(1 hunks)lib/features/home/domain/entities/category.dart(1 hunks)lib/features/home/domain/entities/project.dart(1 hunks)lib/features/home/domain/entities/status.dart(1 hunks)lib/features/home/domain/entities/task.dart(1 hunks)lib/features/home/domain/repository/project_repo.dart(1 hunks)lib/features/home/domain/repository/tasks_repo.dart(1 hunks)lib/features/home/view/bloc/project_bloc.dart(1 hunks)lib/features/home/view/bloc/project_event.dart(1 hunks)lib/features/home/view/bloc/project_state.dart(1 hunks)lib/features/home/view/pages/home_page.dart(3 hunks)lib/features/home/view/widget/data_models.dart(0 hunks)lib/features/home/view/widget/sliding_menu.dart(7 hunks)lib/features/home/view/widget/top_bar.dart(3 hunks)lib/features/home/view/widget/vertical-divider.dart(1 hunks)lib/injection_container.dart(3 hunks)lib/main.dart(3 hunks)pocketbase/main.go(1 hunks)pocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/avatar_i2vogq923e.jpg.attrs(1 hunks)pocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/thumbs_avatar_i2vogq923e.jpg/100x100_avatar_i2vogq923e.jpg.attrs(1 hunks)pubspec.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- lib/features/home/view/widget/data_models.dart
🧰 Additional context used
🪛 golangci-lint (1.64.8)
pocketbase/main.go
81-81: Error return value of app.RunInTransaction is not checked
(errcheck)
🔇 Additional comments (38)
pocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/thumbs_avatar_i2vogq923e.jpg/100x100_avatar_i2vogq923e.jpg.attrs (1)
1-2: LGTM!This metadata file for the user avatar is correctly formatted with all necessary attributes.
lib/features/auth/view/bloc/auth_bloc.dart (1)
127-127: Minor formatting changeThis is just a formatting change adding a space after the opening brace of the catch block.
pocketbase/pb_data/storage/_pb_users_auth_/fxzsz50379852b7/avatar_i2vogq923e.jpg.attrs (1)
1-1: Metadata format has been updated correctly.The metadata has been properly updated to reflect the change from JPEG to PNG format, along with the corresponding MD5 hash update. This ensures proper content type identification when serving the avatar image.
pubspec.yaml (2)
32-32: Good addition of drag_and_drop_lists package.The
drag_and_drop_listspackage (v0.4.2) is an appropriate choice for implementing Kanban board functionality as mentioned in the PR objectives. This will enable drag and drop interactions for tasks.
39-39: Good addition of font_awesome_flutter package.The
font_awesome_flutterpackage (v10.8.0) will provide access to a rich set of icons that can enhance the UI for the task management screens.lib/main.dart (4)
8-8: Import statement added correctly for ProjectBloc.The import for the ProjectBloc has been correctly added, which is needed for the new BlocProvider.
40-42: Proper integration of ProjectBloc with BlocProvider.The ProjectBloc has been correctly integrated using BlocProvider and dependency injection with GetIt (sl). This follows the established pattern in the codebase.
46-46: Route formatting fixed.Unnecessary whitespace has been removed from the route definition.
63-63: Consistent code formatting.Unnecessary whitespace has been removed from the return statement.
lib/features/home/data/models/project_model.dart (1)
1-36: Well-structured ProjectModel implementation.The ProjectModel class is well-implemented, properly extending the Project entity with appropriate constructor, fromJson, and toJson methods. The serialization and deserialization logic is clean and follows best practices.
assets/success_animation.json (1)
1-113: Well-designed success animation added.The animation provides a clear visual indication of success with an animated circle followed by a checkmark. The timing sequence (circle appears first, then checkmark) creates a good visual flow.
lib/features/home/view/bloc/project_event.dart (1)
3-8: Good use of sealed class for event hierarchy.Using a sealed class for the event hierarchy ensures type safety and prevents instantiation of the base class outside this file. This is a good practice for BLoC event modeling.
lib/features/home/Tsak/add-section.dart (4)
4-11: LGTM! Proper widget declaration with required callback.The
AddColumnWidgetclass is correctly defined as a StatefulWidget with a required callback function for adding new columns.
13-23: Good resource management with proper disposal.You're correctly disposing of the TextEditingController and FocusNode in the dispose method to prevent memory leaks.
25-34: LGTM! Well-structured submission method.The
_submitColumnmethod appropriately validates input, calls the callback only if input is not empty, and resets the state.
79-100: LGTM! Good implementation of keyboard handling.The RawKeyboardListener is correctly implemented to handle the Enter key press for form submission, enhancing the user experience.
lib/features/home/domain/repository/project_repo.dart (1)
1-10: LGTM! Well-defined repository interface.The
ProjectRepositoryinterface is well-structured with clear method signatures for CRUD operations on projects.lib/features/home/view/pages/home_page.dart (3)
7-8: LGTM! Proper imports for new functionality.The added imports for task page and project bloc are appropriate for the functionality being implemented.
94-101: LGTM! Clean implementation of sliding menu positioning.The SlidingMenu is correctly positioned using Positioned widget with proper parameters.
120-144: LGTM! Good implementation of conditional UI based on project state.The BlocBuilder is well implemented to conditionally render either the dashboard or task page based on the current project state.
lib/injection_container.dart (3)
36-39: LGTM! Proper imports for new functionality.The added imports for project-related classes are appropriate for the dependency injection setup.
61-63: LGTM! Clean separation of initialization logic.Breaking down the initialization into separate functions for auth and projects improves code organization and maintainability.
113-125: LGTM! Changed to lazy singleton for AuthBloc.Changing AuthBloc registration from factory to lazy singleton is appropriate since it maintains state across the application.
lib/features/home/Tsak/kanban.dart (2)
11-21: LGTM - Good parameter definitionsThe widget constructor properly defines required parameters with clear function signatures for callbacks, making it easy to understand and implement.
376-391: Good empty state implementationThe empty state view with an icon and text provides clear feedback to users when a column has no tasks. This improves the user experience.
lib/features/home/data/data_sources/task_remote_source.dart (1)
5-11: Well-defined interface for task operationsThe abstract class provides a clean interface with appropriate method signatures for all required task operations.
lib/features/home/data/repository/project_repo_impl.dart (1)
5-9: Clean repository implementationThe repository properly implements the interface and follows dependency injection pattern by requiring the data source in the constructor.
lib/features/home/data/data_sources/project_remote_source.dart (1)
20-30: Good error handling in fetchProjectsThe method properly handles exceptions by catching them and returning null, preventing crashes when network issues occur.
lib/features/home/Tsak/task-page.dart (7)
9-12: SimpleTaskmodel
YourTaskdata class is straightforward and well-structured for encapsulating task information.
14-28: FlexibleColumnModel
Storing the title, tasks, color, and icon in one class enables easy management of Kanban column properties and behaviors.
30-34:DraggedTaskDatafits drag-and-drop needs
This model neatly encapsulates the dragged task and its origin column, supporting flexible drag-and-drop operations.
36-42: StatefulTaskPage
Using aStatefulWidgetis appropriate for trackable changes and dynamic UI updates within the task management interface.
79-93: Well-structured column addition
The_addColumnfunction is clear and ensures that only valid (non-empty) column titles are allowed.
95-102: Robust column reorder logic
By correctly preventing out-of-range reorders and applying the standard ReorderableListView pattern, this method keeps the columns organized without errors.
104-159: Sleek build withReorderableListView
Your integration ofReorderableListView.builderand separate widgets for columns and the “Add Column” action provides a clean user experience.lib/features/home/view/widget/sliding_menu.dart (3)
6-13: Added necessary imports
The newly introduced imports for bloc usage, project entities, and the service locator align well with the updated state management approach.
15-27: Refactoring toStatefulWidget
ConvertingSlidingMenuto aStatefulWidgetmakes sense for managing asynchronous data and showing real-time updates.
90-101: Menu content structure
The switch-case approach for different menu items is easy to follow and keeps the logic well-organized.
| import 'package:task_app/features/auth/domain/entities/user.dart'; | ||
| import 'package:task_app/features/home/domain/entities/Board.dart'; | ||
|
|
There was a problem hiding this comment.
Fix import casing to ensure cross-platform compatibility.
The import for Board has a capital 'B' in the path which doesn't match the actual filename (board.dart) shown in the previous file. This inconsistency could cause issues on case-sensitive file systems.
import 'package:task_app/features/auth/domain/entities/user.dart';
-import 'package:task_app/features/home/domain/entities/Board.dart';
+import 'package:task_app/features/home/domain/entities/board.dart';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import 'package:task_app/features/auth/domain/entities/user.dart'; | |
| import 'package:task_app/features/home/domain/entities/Board.dart'; | |
| import 'package:task_app/features/auth/domain/entities/user.dart'; | |
| import 'package:task_app/features/home/domain/entities/board.dart'; |
| this.height = 40, | ||
| this.width = 25, | ||
| this.thickness = 2, | ||
| this.color = Colors.teal, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Use theme colors instead of hardcoded values
Hardcoding Colors.teal might not match your app's theme across different contexts. Consider using Theme.of(context).dividerColor or a similar theme-aware approach.
- this.color = Colors.teal,
+ this.color = Colors.grey, // Will be replaced with theme color in build method📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| this.color = Colors.teal, | |
| this.color = Colors.grey, // Will be replaced with theme color in build method |
| analyzer: | ||
| errors: | ||
| library_private_types_in_public_api: ignore | ||
| use_build_context_synchronously: ignore |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Document reasons for disabling analyzer rules
Disabling analyzer rules can lead to potential bugs. These two rules in particular protect against:
library_private_types_in_public_api: Exposing private implementation details in public APIsuse_build_context_synchronously: Using BuildContext after an asynchronous gap which may cause bugs if the widget is unmounted
Consider adding comments explaining why these rules are being ignored, or better yet, fix the underlying issues instead of disabling the rules.
analyzer:
errors:
- library_private_types_in_public_api: ignore
- use_build_context_synchronously: ignore
+ # Ignored because we have many StatefulWidgets with _State classes in our codebase
+ # TODO: Refactor to use proper naming conventions
+ library_private_types_in_public_api: ignore
+
+ # Ignored because we've implemented proper state management to ensure
+ # BuildContext is valid when used after async operations
+ # TODO: Add mounted checks where BuildContext is used after await
+ use_build_context_synchronously: ignore📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| analyzer: | |
| errors: | |
| library_private_types_in_public_api: ignore | |
| use_build_context_synchronously: ignore | |
| analyzer: | |
| errors: | |
| # Ignored because we have many StatefulWidgets with _State classes in our codebase | |
| # TODO: Refactor to use proper naming conventions | |
| library_private_types_in_public_api: ignore | |
| # Ignored because we've implemented proper state management to ensure | |
| # BuildContext is valid when used after async operations | |
| # TODO: Add mounted checks where BuildContext is used after await | |
| use_build_context_synchronously: ignore |
| import 'package:flutter/material.dart'; | ||
| import 'package:task_app/core/config/config.dart'; | ||
| import 'package:task_app/features/auth/domain/entities/user.dart'; | ||
| import 'package:task_app/features/home/view/widget/hoverIcon_button.dart'; | ||
| import 'package:task_app/features/home/view/widget/vertical-divider.dart'; | ||
|
|
There was a problem hiding this comment.
Directory name "Tsak" appears to be a typo.
The directory path lib/features/home/Tsak/ should likely be lib/features/home/Task/.
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter/services.dart'; | ||
|
|
||
| class AddColumnWidget extends StatefulWidget { | ||
| final Function(String) onAddColumn; | ||
|
|
||
| AddColumnWidget({required this.onAddColumn}); | ||
|
|
||
| @override | ||
| _AddColumnWidgetState createState() => _AddColumnWidgetState(); | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Check the folder name spelling.
The folder name "Tsak" appears to be a typo and should be "Task". This could lead to confusion and inconsistency in your codebase organization.
🏁 Script executed:
#!/bin/bash
# Check if there are other files/folders with similar naming patterns
echo "Checking folder structure and naming patterns..."
find lib -type d -name "Task" # Check if Task folder exists
find lib -type d -name "Tsak" # Confirm Tsak folder existsLength of output: 189
Rename Folder for Consistent Naming
The folder currently named "lib/features/home/Tsak" appears to be a typographical error. To maintain consistency across the codebase, please rename "Tsak" to "Task". Additionally, verify that any references to this folder in your code are updated accordingly.
| @override | ||
| List<Object?> get props => [currentProject]; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Include all relevant properties in props.
The props getter only includes currentProject but not projects, which means equality checks will only consider the currentProject property. This could lead to unexpected behavior when the projects list changes but the currentProject remains the same.
@override
- List<Object?> get props => [currentProject];
+ List<Object?> get props => [currentProject, projects];📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @override | |
| List<Object?> get props => [currentProject]; | |
| } | |
| @override | |
| List<Object?> get props => [currentProject, projects]; | |
| } |
| @override | ||
| Future<List<Task>> getTasks() async { | ||
| return await remoteDataSource.fetchTasks(); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add error handling for remote operations.
The current implementation doesn't handle potential errors from the remote data source.
Consider adding try-catch blocks to handle errors:
@override
Future<List<Task>> getTasks() async {
- return await remoteDataSource.fetchTasks();
+ try {
+ return await remoteDataSource.fetchTasks();
+ } catch (e) {
+ // Log the error and consider a more appropriate error handling strategy
+ // For example, return an empty list or rethrow with a custom exception
+ throw Exception('Failed to fetch tasks: $e');
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @override | |
| Future<List<Task>> getTasks() async { | |
| return await remoteDataSource.fetchTasks(); | |
| } | |
| @override | |
| Future<List<Task>> getTasks() async { | |
| try { | |
| return await remoteDataSource.fetchTasks(); | |
| } catch (e) { | |
| // Log the error and consider a more appropriate error handling strategy | |
| // For example, return an empty list or rethrow with a custom exception | |
| throw Exception('Failed to fetch tasks: $e'); | |
| } | |
| } |
| @override | ||
| Future<ProjectModel> createProject(Map<String, dynamic> projectData) async { | ||
| final record = | ||
| await pocketBase.collection('projects').create(body: projectData); | ||
| return ProjectModel.fromJson(record.toJson()); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add error handling to createProject method
Unlike fetchProjects and getProject, this method doesn't have try-catch error handling. Add consistent error handling across all methods.
@override
Future<ProjectModel> createProject(Map<String, dynamic> projectData) async {
+ try {
final record =
await pocketBase.collection('projects').create(body: projectData);
return ProjectModel.fromJson(record.toJson());
+ } catch (e) {
+ print('Error creating project: $e');
+ throw Exception('Failed to create project: $e');
+ }
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @override | |
| Future<ProjectModel> createProject(Map<String, dynamic> projectData) async { | |
| final record = | |
| await pocketBase.collection('projects').create(body: projectData); | |
| return ProjectModel.fromJson(record.toJson()); | |
| } | |
| @override | |
| Future<ProjectModel> createProject(Map<String, dynamic> projectData) async { | |
| try { | |
| final record = | |
| await pocketBase.collection('projects').create(body: projectData); | |
| return ProjectModel.fromJson(record.toJson()); | |
| } catch (e) { | |
| print('Error creating project: $e'); | |
| throw Exception('Failed to create project: $e'); | |
| } | |
| } |
…er functionality and user assignment dialog
3 participants
Summary by CodeRabbit
New Features
Refactor
Chores