Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Serve operators source#290

Closed
vlegakis wants to merge 4 commits intomainfrom
vlegakis/walrus-operators
Closed

Serve operators source#290
vlegakis wants to merge 4 commits intomainfrom
vlegakis/walrus-operators

Conversation

@vlegakis
Copy link
Contributor

No description provided.

@vlegakis vlegakis requested a review from mlegner March 10, 2025 18:52
@vlegakis vlegakis self-assigned this Mar 10, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://MystenLabs.github.io/walrus-docs/pr-preview/pr-290/

Built to branch gh-pages at 2025-03-10 18:53 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@vlegakis vlegakis requested a review from nikos-terzo March 10, 2025 19:11
Copy link
Collaborator

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this, @vlegakis! I generally agree with the approach to put the URLs into a JSON file and inserting them in the docs. I have a few more detailed questions.

@@ -0,0 +1,128 @@
{
"aggregators": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are you using an object where the URLs are the keys to make it extensible in the future? E.g., adding info about who runs it, its location, etc.?

"https://walrus-testnet.validators.services.kyve.network/publish": {},
"http://walrus-publisher-testnet.suisec.tech:9001": {}
}
} No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we add a final new line?

Suggested change
}
}

Comment on lines -318 to -341

The field `event` returns the [Sui event ID](../dev-guide/sui-struct.md) that can be used to
find the transaction that created the Sui Blob object on the Sui explorer or using a Sui SDK.

### Read

Blobs may be read from an aggregator or daemon using HTTP GET. For example, the following cURL
command reads a blob and writes it to an output file:

```sh
curl "$AGGREGATOR/v1/blobs/<some blob ID>" -o <some file name>
```

Alternatively you may print the contents of a blob in the terminal with the cURL command:

```sh
curl "$AGGREGATOR/v1/blobs/<some blob ID>"
```

```admonish tip title="Content sniffing"
Modern browsers will attempt to sniff the content type for such resources, and will generally do a
good job of inferring content types for media. However, the aggregator on purpose prevents such
sniffing from inferring dangerous executable types such as JavaScript or style sheet types.
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why is this removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why is this needed? We already deploy the docs with the publish.yaml workflow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Didn't know that! Will remove

cargo install mdbook-admonish@1.18.0 --locked
cargo install mdbook-katex@0.9.0 --locked
cargo install mdbook-i18n-helpers --locked
cargo install mdbook-variables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: This will probably have to be added to the build-mdbook action.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the preview looks like this:
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Where/how is this used?

Copy link
Contributor Author

@vlegakis vlegakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a draft PR to make sure the approach is correct. Independent issues noted will be fixed. Thanks for the feedback @mlegner !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Didn't know that! Will remove

@vlegakis vlegakis closed this Mar 13, 2025
@vlegakis vlegakis deleted the vlegakis/walrus-operators branch March 13, 2025 14:21
@vlegakis
Copy link
Contributor Author

Closed in favor of #293

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants