Skip to content

Add Dockerfile for Flask app#9

Open
lockefox wants to merge 24 commits intoN2ITN:masterfrom
lockefox:master
Open

Add Dockerfile for Flask app#9
lockefox wants to merge 24 commits intoN2ITN:masterfrom
lockefox:master

Conversation

@lockefox
Copy link
Copy Markdown

@lockefox lockefox commented Mar 18, 2018

  • Reviews PEP8 compliance
  • Adds setup.py for packaging
    • Collects ALL requirements (not just Flask app ones)
  • Adds Dockerfile for serving Flask website + gunicorn
  • Moves scrap code into /scraps path, to be deleted?
  • Moves ipynb files into /notebooks path
  • Adds CONTRIBUTORS file to track authors
  • Converts README from markdown to re-structured text (Python preferred format)
  • Adds some useful TODO notes for future refactoring
  • Changes requests pattern for better stability

install_requires=[
'beautifulsoup4',
'boto3',
'python-dateutil~=2.6.0', # BUGFIX: boto3 vs python-dateutil==2.7.0
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longterm TODO: split app concerns between scraper/trainer/Flask. All apps share one requirements list.

Biggest imports slowing building down:

  • sklearn
  • beautifulsoup4
  • nltk

@lockefox
Copy link
Copy Markdown
Author

Should add to README:

..code-block: bash
    docker build -t fakenews_flask -f Dockerfile .
    docker run -d -p 5000:5000 fakenews_flask

@lockefox
Copy link
Copy Markdown
Author

lockefox commented May 7, 2018

merge me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant