Skip to content

fix(GLTFExtensionsPlugin.d.ts): make all parameters optional#908

Merged
gkjohnson merged 6 commits intoNASA-AMMOS:masterfrom
sguimmara:typing-GLTFExtensionsPlugin
Jan 8, 2025
Merged

fix(GLTFExtensionsPlugin.d.ts): make all parameters optional#908
gkjohnson merged 6 commits intoNASA-AMMOS:masterfrom
sguimmara:typing-GLTFExtensionsPlugin

Conversation

@sguimmara
Copy link
Contributor

@sguimmara sguimmara commented Jan 7, 2025

This PR fixes the .d.ts files for various plugins so that the signature for optional parameters matches what the Javascript version accepts.

@sguimmara sguimmara marked this pull request as draft January 7, 2025 13:46
@sguimmara sguimmara marked this pull request as ready for review January 7, 2025 13:48
@gkjohnson gkjohnson added this to the v0.4.1 milestone Jan 7, 2025
@gkjohnson
Copy link
Contributor

Thanks!

@gkjohnson gkjohnson merged commit 51cb07d into NASA-AMMOS:master Jan 8, 2025
2 checks passed
@sguimmara sguimmara deleted the typing-GLTFExtensionsPlugin branch January 14, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants